From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46254 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726358AbfG2KQe (ORCPT ); Mon, 29 Jul 2019 06:16:34 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6TAE4R5134459 for ; Mon, 29 Jul 2019 06:16:33 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2u1wq83k4x-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 29 Jul 2019 06:16:33 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Jul 2019 11:16:31 +0100 Date: Mon, 29 Jul 2019 12:16:26 +0200 From: Vasily Gorbik Subject: Re: [PATCH] vfio-ccw: make vfio_ccw_async_region_ops static References: <20190729111640.4c03169c.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190729111640.4c03169c.cohuck@redhat.com> Message-Id: Sender: linux-s390-owner@vger.kernel.org List-ID: To: Cornelia Huck Cc: linux-s390 On Mon, Jul 29, 2019 at 11:16:40AM +0200, Cornelia Huck wrote: > On Mon, 29 Jul 2019 10:38:52 +0200 > Vasily Gorbik wrote: > > > Since vfio_ccw_async_region_ops is not exported and has no reason to be > > globally visible make it static to avoid the following sparse warning: > > drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static? > > Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions") > > > > Signed-off-by: Vasily Gorbik > > --- > > drivers/s390/cio/vfio_ccw_async.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/s390/cio/vfio_ccw_async.c b/drivers/s390/cio/vfio_ccw_async.c > > index 8c1d2357ef5b..7a838e3d7c0f 100644 > > --- a/drivers/s390/cio/vfio_ccw_async.c > > +++ b/drivers/s390/cio/vfio_ccw_async.c > > @@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private, > > > > } > > > > -const struct vfio_ccw_regops vfio_ccw_async_region_ops = { > > +static const struct vfio_ccw_regops vfio_ccw_async_region_ops = { > > .read = vfio_ccw_async_region_read, > > .write = vfio_ccw_async_region_write, > > .release = vfio_ccw_async_region_release, > > Reviewed-by: Cornelia Huck > > Should I queue this and send a pull request (currently, there's nothing > else pending), or do you want to apply this directly? Then I'll just take it directly to avoid pull request overhead, thanks!