Re: [PATCH 2/2] s390/iucv: Fix vargs handling in iucv_alloc_device()

Vasily Gorbik
2024-08-13T14:36:17Z

On Tue, Aug 13, 2024 at 03:35:48PM +0200, Alexandra Winter wrote:
>
>
> On 13.08.24 14:43, Greg Kroah-Hartman wrote:
> >>> I don't understand, why can't dev_set_name() be called here?
> >>>
> [...]
> >
> > But step back, why is this needed at all anyway? No other subsystem or
> > driver needs/wants this, what makes this api so special? Why not figure
> > out your name beforehand?
> >
> > thanks,
>
>
> Vasily, the following update to Heiko's patch does not touch lib/kobject.c
> According to a quick test it still solves the original issue and does compile
> with W=1 and iucv as a module.
>
> diff --git a/net/iucv/iucv.c b/net/iucv/iucv.c
> index 64102a31b569..6a819ba4ccab 100644
> --- a/net/iucv/iucv.c
> +++ b/net/iucv/iucv.c
> @@ -86,13 +86,17 @@ struct device *iucv_alloc_device(const struct attribute_group **attrs,
> {
> struct device *dev;
> va_list vargs;
> + char buf[20];
> int rc;
>
> dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> if (!dev)
> goto out_error;
> va_start(vargs, fmt);
> - rc = kobject_set_name_vargs(&dev->kobj, fmt, vargs);
> + rc = vsnprintf(buf, 20, fmt, vargs);
> + if (!rc)
> + rc = dev_set_name(dev, buf);
> va_end(vargs);
> if (rc)
> goto out_error;
>
> Maybe Greg has somethign like this in mind?

Thanks Alexandra,

but I'm still leaning towards forwarding vargs and avoid splitting the name
formatting logic, if Greg agrees that the use case justifies adding a
new helper. Let's see what Greg prefers.

int dev_set_name_vargs(struct device *dev, const char *fmt, va_list vargs)
{
return kobject_set_name_vargs(&dev->kobj, fmt, vargs);
}
EXPORT_SYMBOL_GPL(dev_set_name_vargs)