From: Sven Schnelle <svens@linux.ibm.com>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-s390@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: fix writing of uncompressed size
Date: Mon, 11 Jul 2022 11:34:00 +0200 [thread overview]
Message-ID: <yt9dy1x03sdz.fsf@linux.ibm.com> (raw)
In-Reply-To: <CAPpZLN4LYUs4UrQ7EpAUcsh2qNJnaV9JHZKBJ-RUUkrU_1d73A@mail.gmail.com> (Tzvetomir Stoyanov's message of "Mon, 11 Jul 2022 12:25:08 +0300")
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> writes:
>> I see that 'handle->pointer' is unsigned long, which is 8 bytes on
>> s390. But it is converted as 4 byte int. That would work on LE
>> platforms, but not on BE.
>
> Yes, that looks like a problem. I think the best fix is to change
> 'handle->pointer' to unsigned int, can you test that on s390? There is
> no need of 8 bytes for that size, unsigned int should be OK. This is
> the size of one data chunk, it should not exceed 4G. Do you want to
> submit such a fix, if it works on s390?
Yes, converting it to unsigned int works. I'll submit a fix.
Thanks!
Sven
next prev parent reply other threads:[~2022-07-11 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 7:44 [PATCH] trace-cmd: fix writing of uncompressed size Sven Schnelle
2022-07-11 8:55 ` Tzvetomir Stoyanov
2022-07-11 9:06 ` Sven Schnelle
2022-07-11 9:14 ` Sven Schnelle
2022-07-11 9:25 ` Tzvetomir Stoyanov
2022-07-11 9:34 ` Sven Schnelle [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-11 18:21 [PATCH] trace-cmd: Fix " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9dy1x03sdz.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).