From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.1030.1601930399005992866 for ; Mon, 05 Oct 2020 13:39:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=K7DTrK0G; spf=pass (domain: gmail.com, ip: 209.85.221.66, mailfrom: sudipm.mukherjee@gmail.com) Received: by mail-wr1-f66.google.com with SMTP id m6so11092589wrn.0 for ; Mon, 05 Oct 2020 13:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=s6iDC9dUHJsp946AwvB4HqOpH0+Gyt+ZQFRpxT0XcVA=; b=K7DTrK0GdYHxog7SsY1N3+Kxz2lpMsx9Ntecvkbxy7EnP7KNodDTxm4vg9KgPVRrkp oERbErfELiAWgBC7sy+G9vkMbUhcOd/3Ouop8+32yTbCP+lW4XfInqX6YQsvm1jxvDw5 IlTOcH0P09hkLrPat1IgfcU3HXAfRyBbCAFmBWyd2y7bVPo7HwubzU0tGB2Mt6JG8PfR VEAB9TSw4ahUGoA4exHQmC2laANryX350/O3xDEPJXKo3Qb+88SDbgu0swk12fDoUZv2 cMeCfDKbOsaKyI5Lyfw48BjpviW5aDNKQMVIkHffZYTSXAD/JchcIrEkgR4eiNCJhODJ GrNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=s6iDC9dUHJsp946AwvB4HqOpH0+Gyt+ZQFRpxT0XcVA=; b=LYao6D253lZxtiHn4dYVIFhNY6fLsaYHOYGwyRhZC6eijQm4y37oVSSWG1JDvYEyTv lqYfUWzqM2UiclCYEXQXWjzHLd6w0uCY/L0sGUyNKCVRcIOAWstDawndzMY81beqLosP ZB409i+1Om95uzlbMjsIUmVpzM9M3FG3JCDQ2Z0KBgdYRLTJlLs0/Y3sJwl/VHRUP6QF uDNdeiYkOKidBG+UnSuVwuUPv2IfmYoRVIFWwLuEPxwvu/gJj8cpT5w9HM0+8al2vy0F NECO3jFqrlmnX2vhlBzOTmK9rXgzNhd7SUp2o7+WTzMbD2ukuHog3YRc1zlVyywvu7Ih AoGA== X-Gm-Message-State: AOAM532y05OysXCTHLq1QL6475yEWUQEgO7tN2nPAMqXQiQGQb8fvZ7y nUKgBNZm6XNow903S/8JUPc= X-Google-Smtp-Source: ABdhPJzFSr8+CEKAseUSNhBRTaD/bhR4pMFdNpvhT9e1yKN0zIQNhueuD86vXnYgCViRRH7kKSF7Tg== X-Received: by 2002:adf:9504:: with SMTP id 4mr1207472wrs.27.1601930397364; Mon, 05 Oct 2020 13:39:57 -0700 (PDT) Return-Path: Received: from localhost.localdomain (host-92-5-241-147.as43234.net. [92.5.241.147]) by smtp.gmail.com with ESMTPSA id t13sm882079wmj.15.2020.10.05.13.39.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Oct 2020 13:39:56 -0700 (PDT) From: Sudip Mukherjee To: Luis Chamberlain , Kees Cook , Iurii Zaikin Cc: linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech, linux-fsdevel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap() Date: Mon, 5 Oct 2020 21:37:49 +0100 Message-Id: <20201005203749.28083-1-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 2.11.0 The variable 'first' is assigned 0 inside the while loop in the if block but it is not used in the if block and is only used in the else block. So, remove the unneeded assignment. Signed-off-by: Sudip Mukherjee --- The resultant binary stayed same after this change. Verified with md5sum which remained same with and without this change. $ md5sum kernel/sysctl.o e9e97adbfd3f0b32f83dd35d100c0e4e kernel/sysctl.o kernel/sysctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index ce75c67572b9..b51ebfd1ba6e 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1508,7 +1508,6 @@ int proc_do_large_bitmap(struct ctl_table *table, int write, } bitmap_set(tmp_bitmap, val_a, val_b - val_a + 1); - first = 0; proc_skip_char(&p, &left, '\n'); } left += skipped; -- 2.11.0