From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web08.8104.1604643741506491196 for ; Thu, 05 Nov 2020 22:22:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eXFlA98X; spf=pass (domain: gmail.com, ip: 209.85.128.65, mailfrom: lukas.bulwahn@gmail.com) Received: by mail-wm1-f65.google.com with SMTP id c16so268862wmd.2 for ; Thu, 05 Nov 2020 22:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=s5ZmG5HziDA6IddsEwKpYTRZvML0z6aMnCT2nnV/iGw=; b=eXFlA98XsP9bNmMIrUbtLEH8DNqvq47SPuGmJHCzfmWSp1fR1x2j++BW+WQOKtNHpy +n08HtlcerjUblGu7gVJIEAE8snqfmrKwkHUBhVmckyOAifi9wl/MLGB+j8fZnAhKgft AGf/TnfJECJbQhkZd5NaLUOE+dB2HmNcP1cXmptgfCEcvh2ESOWwr8viqYLL3qrflwQ4 ej9EnxUhE9BBa/UQrjg+TYA/zGHhHUF5z3raVSr5MypFVjkjv0/u1pitZf2oUcQxMax5 RehF139mRg36hUXiXbPwOZYby58Feh1Zu8IX5dkdNtsMdC9/SYNEfYpNKEiRcDbBCiqK Sc3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=s5ZmG5HziDA6IddsEwKpYTRZvML0z6aMnCT2nnV/iGw=; b=WglSu+2ngTKl677c+Kk49QzJJaJi9E5aQbgperKVGzBItTvUL/wJZaocslJwf10fvU cP/9q59FKkIQWstld5yIuCc0dN8YAe3dpeMBMNDikW5lSgBzTszRYChH1gfuQ0mmmstr wyzZLTKpV38OI92r7QDHlPoAF2se/V1MTIaXE8elulMIp55UwcsPFHgZbxbHhKcQJqPQ bLMJFs5+UGBwZSC2CQBiOIn/ink5/YH+yXQDWyHsVfPLbPcj75hLBnWLUaheJIdpBO6v +Yt2Eckuaik2aOkc5CTO1zfNgUzuSrLMH8ZdIHtPAjmhkaKizbflZHIrG1AAb0wb4uzi CoGw== X-Gm-Message-State: AOAM530r4oxtRbxkg5twM85izPjoIS6Fyq6o+ftiIsexbq7B18m6sCIe rkCQnps2MUxbuK1u5sKgTaE= X-Google-Smtp-Source: ABdhPJw1kNpLxAin7EGLXZO9jr3KRSf4YMHdtk5JEmho3ZDLTxUMoNc/quG7fq3c5nak5We4cIg9ig== X-Received: by 2002:a1c:a503:: with SMTP id o3mr613462wme.21.1604643739995; Thu, 05 Nov 2020 22:22:19 -0800 (PST) Return-Path: Received: from felia.fritz.box ([2001:16b8:2d20:9d00:b87b:b644:61a3:6870]) by smtp.gmail.com with ESMTPSA id h81sm612401wmf.44.2020.11.05.22.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 22:22:19 -0800 (PST) From: "Lukas Bulwahn" To: Balbir Singh Cc: Tom Rix , Nathan Chancellor , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-janitors@vger.kernel.org, linux-safety@lists.elisa.tech, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH] taskstats: remove unneeded dead assignment Date: Fri, 6 Nov 2020 07:22:10 +0100 Message-Id: <20201106062210.27920-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.17.1 make clang-analyzer on x86_64 defconfig caught my attention with: kernel/taskstats.c:120:2: warning: Value stored to 'rc' is never read \ [clang-analyzer-deadcode.DeadStores] rc = 0; ^ Commit d94a041519f3 ("taskstats: free skb, avoid returns in send_cpu_listeners") made send_cpu_listeners() not return a value and hence, the rc variable remained only to be used within the loop where it is always assigned before read and it does not need any other initialisation. So, simply remove this unneeded dead initializing assignment. As compilers will detect this unneeded assignment and optimize this anyway, the resulting object code is identical before and after this change. No functional change. No change to object code. Signed-off-by: Lukas Bulwahn --- applies cleanly on current master and next-20201105 Balbir, please pick this minor non-urgent clean-up patch. kernel/taskstats.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/taskstats.c b/kernel/taskstats.c index a2802b6ff4bb..bd18a7bf5276 100644 --- a/kernel/taskstats.c +++ b/kernel/taskstats.c @@ -117,7 +117,6 @@ static void send_cpu_listeners(struct sk_buff *skb, genlmsg_end(skb, reply); - rc = 0; down_read(&listeners->sem); list_for_each_entry(s, &listeners->list, list) { skb_next = NULL; -- 2.17.1