From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony K Nadackal Subject: RE: [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function Date: Mon, 05 Jan 2015 10:41:55 +0530 Message-ID: <000001d028a6$2da27c90$88e775b0$@samsung.com> References: <1418797339-27877-1-git-send-email-tony.kn@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:50957 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbbAEFLT (ORCPT ); Mon, 5 Jan 2015 00:11:19 -0500 In-reply-to: <1418797339-27877-1-git-send-email-tony.kn@samsung.com> Content-language: en-us Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: mchehab@osg.samsung.com, j.anaszewski@samsung.com, kgene@kernel.org, k.debski@samsung.com, s.nawrocki@samsung.com, bhushan.r@samsung.com, tony.kn@samsung.com Gentle Reminder. Thanks Tony > -----Original Message----- > From: Tony K Nadackal [mailto:tony.kn@samsung.com] > Sent: Wednesday, December 17, 2014 11:52 AM > To: linux-media@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org > Cc: mchehab@osg.samsung.com; j.anaszewski@samsung.com; > kgene@kernel.org; k.debski@samsung.com; s.nawrocki@samsung.com; > bhushan.r@samsung.com; Tony K Nadackal > Subject: [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset > function > > Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared on > software reset. These bits need to be cleared explicitly. > > Signed-off-by: Tony K Nadackal > --- > This patch is created and tested on top of linux-next-20141210. > It can be cleanly applied on media-next and kgene/for-next. > > > drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > index ab6d6f43..e53f13a 100644 > --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > @@ -21,6 +21,10 @@ void exynos4_jpeg_sw_reset(void __iomem *base) > unsigned int reg; > > reg = readl(base + EXYNOS4_JPEG_CNTL_REG); > + writel(reg & ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE), > + base + EXYNOS4_JPEG_CNTL_REG); > + > + reg = readl(base + EXYNOS4_JPEG_CNTL_REG); > writel(reg & ~EXYNOS4_SOFT_RESET_HI, base + > EXYNOS4_JPEG_CNTL_REG); > > udelay(100); > -- > 2.2.0