From: "Jingoo Han" <jingoohan1@gmail.com>
To: 'Jeffy Chen' <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: 'Daniel Vetter' <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
'Laurent Pinchart' <Laurent.pinchart@ideasonboard.com>,
'Marek Szyprowski' <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, briannorris@chromium.org,
'Krzysztof Kozlowski' <krzk@kernel.org>,
linux-rockchip@lists.infradead.org,
'Kukjin Kim' <kgene@kernel.org>,
'Caesar Wang' <wxt@rock-chips.com>,
broonie@kernel.org, linux-arm-kernel@lists.infradead.org,
rjw@rjwysocki.net, 'zain wang' <wzz@rock-chips.com>,
'Tomeu Vizoso' <tomeu.vizoso@collabora.com>,
dmitry.torokhov@gmail.com,
'Seung-Woo Kim' <sw0312.kim@samsung.com>,
dianders@chromium.org, tfiga@chromium.org,
'Kyungmin Park' <kyungmin.park@samsung.com>
Subject: Re: [RFC PATCH v3 3/5] drm/bridge/analogix: Do not use device's drvdata
Date: Tue, 17 Oct 2017 19:42:38 -0400 [thread overview]
Message-ID: <000001d347a1$9f11ffa0$dd35fee0$@gmail.com> (raw)
In-Reply-To: <20171017080925.23763-4-jeffy.chen@rock-chips.com>
On Tuesday, October 17, 2017 4:09 AM, Jeffy Chen wrote:
>
> From: Tomasz Figa <tfiga@chromium.org>
>
> The driver that instantiates the bridge should own the drvdata, as all
> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
> owned by its driver struct. Moreover, storing two different pointer
> types in driver data depending on driver initialization status is barely
> a good practice and in fact has led to many bugs in this driver.
>
> Let's clean up this mess and change Analogix entry points to simply
> accept some opaque struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
>
> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 50 +++++++++--------
> -----
> drivers/gpu/drm/exynos/exynos_dp.c | 26 ++++++-----
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 47
+++++++++++-------
> --
> include/drm/bridge/analogix_dp.h | 19 ++++----
> 4 files changed, 73 insertions(+), 69 deletions(-)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-10-17 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 8:09 [RFC PATCH v3 0/5] rockchip: kevin: Enable edp display Jeffy Chen
2017-10-17 8:09 ` [RFC PATCH v3 3/5] drm/bridge/analogix: Do not use device's drvdata Jeffy Chen
2017-10-17 23:42 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d347a1$9f11ffa0$dd35fee0$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeffy.chen@rock-chips.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=sw0312.kim@samsung.com \
--cc=tfiga@chromium.org \
--cc=tomeu.vizoso@collabora.com \
--cc=wxt@rock-chips.com \
--cc=wzz@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox