Re: [PATCH] ARM: dts: disable PCIe for SD5v1 board

[Jingoo Han <jg1.han@samsung.com>]

On Monday, October 28, 2013 1:52 PM, Olof Johansson wrote:
> On Wed, Sep 4, 2013 at 11:08 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> > Disable PCIe for SD5v1 board, because there is no PCIe slot
> > on SD5v1 board.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > Tested on SD5v1 board.
> >
> >  arch/arm/boot/dts/exynos5440-sd5v1.dts |    7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> > index 5b22508..78a239d 100644
> > --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> > +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> > @@ -36,4 +36,11 @@
> >                 status = "disabled";
> >         };
> >
> > +       pcie@290000 {
> > +               status = "disabled";
> > +       };
> > +
> > +       pcie@2a0000 {
> > +               status = "disabled";
> > +       };
> >  };
> 
> Usually IP blocks like these are always left disabled in the dtsi, and
> explicitly _enabled_ in the DTS on boards that make use of that part
> of the chip.
> So the real solution here should be to move the disabling to the 5440
> .dtsi instead.

OK, right.
Thank you for your guidance.

Then, do you mean the following?
If it is right, I will send the v2 patch.

./arch/arm/boot/dts/exynos5440.dtsi
	pcie@290000 {
		.....
		status = "disabled";
	};
	pcie@2a0000 {
		.....
		status = "disabled";
	};

./arch/arm/boot/dts/exynos5440-ssdk5440.dts
	pcie@290000 {
		.....
		status = "okay";
	};
	pcie@2a0000 {
		.....
		status = "okay";
	};

Best regards,
Jingoo Han