From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Date: Mon, 29 Nov 2010 19:15:03 +0900 Message-ID: <000201cb8fae$4d61fd20$e825f760$%kim@samsung.com> References: <1289030074-5233-1-git-send-email-anarsoul@gmail.com> <1289247983-20747-1-git-send-email-anarsoul@gmail.com> <201011291156.09784.anarsoul@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:48057 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822Ab0K2KPO (ORCPT ); Mon, 29 Nov 2010 05:15:14 -0500 Received: from epmmp2 (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LCN00G2D5SGA260@mailout4.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 29 Nov 2010 19:14:40 +0900 (KST) Received: from DOKGENEKIM02 ([12.23.103.104]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LCN002E35SF08@mmp2.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 29 Nov 2010 19:14:40 +0900 (KST) In-reply-to: <201011291156.09784.anarsoul@gmail.com> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Vasily Khoruzhick' , 'Ben Dooks' , 'Russell King' Cc: 'Lars-Peter Clausen' , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 'Abdoulaye Walsimou GAYE' Vasily Khoruzhick wrote: > > On Monday 08 November 2010 22:26:23 Vasily Khoruzhick wrote: > > Currently the {set,get}_pull callbacks of the s3c24xx_gpiocfg_default > > structure are initalized via s3c_gpio_{get,set}pull_1up. This results in a > > linker error when compiling kernel for s3c2442: > > > > arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f4): undefined reference to > > `s3c_gpio_getpull_1up' > > arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f8): undefined reference to > > `s3c_gpio_setpull_1up' > > > > The s3c2442 has pulldowns instead of pullups compared to the s3c2440. > > The method of controlling them is the same though. > > So this patch modifies the existing s3c_gpio_{get,set}pull_1up helper > > functions to take an additional parameter deciding whether the pin has a > > pullup or pulldown. The s3c_gpio_{get,set}pull_1{down,up} functions then > > wrap that functions passing either S3C_GPIO_PULL_UP or S3C_GPIO_PULL_DOWN. > > > > Furthermore this patch sets up the s3c24xx_gpiocfg_default.{get,set}_pull > > fields in the s3c2442 cpu init function to the new pulldown helper > > functions. > > > > Based on patch from "Lars-Peter Clausen" > > Hi there, > > Can any samsung-soc maintainer review/merge this patch? > > I should admit that merging patches through samsung maintainers became pretty > impossible - response latency is about 1 month, some patches (not mine) are > still pending. I've sent first version of this patch on 6th of November, few > weeks of standby - and we'll get 2.6.37 with broken s3c2442 support. Yeah, I > know that maintainers are living people too, and they need to pay attention > to > real life, work, family, etc, but now merging some samsung-soc-related patch > is really painfull and slow proccess, and it would be nice if it could be > somehow improved. > Hi, Actually, I didn't get your patch through my e-mail. Maybe you missed my e-mail in Cc at that time and I missed your patch in mailing list. Could you please re-send it so that can get the patch via e-mail? Now, thanks for adding me, will review... I think, we have some time to fix it for 37, so don't worry about broken 37-stable. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.