From: Jingoo Han <jg1.han@samsung.com>
To: 'Arnd Bergmann' <arnd@arndb.de>,
'Herbert Xu' <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org,
"'David S. Miller'" <davem@davemloft.net>,
'Naveen Krishna Chatradhi' <ch.naveen@samsung.com>,
'Tomasz Figa' <t.figa@samsung.com>,
linux-samsung-soc@vger.kernel.org,
'Vladimir Zapolskiy' <vz@mleia.com>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] crypto: s5p-sss: fix multiplatform build
Date: Mon, 12 May 2014 11:31:05 +0900 [thread overview]
Message-ID: <000701cf6d8a$399b0990$acd11cb0$%han@samsung.com> (raw)
In-Reply-To: <4525493.CM3akEXMYf@wuerfel>
On Friday, May 09, 2014 8:36 PM, Arnd Bergmann wrote:
>
> As we are preparing to enable multiplatform support on EXYNOS,
> we can no longer include mach/*.h or plat/*.h headers from device
> drivers.
>
> The s5p-sss driver was just enabled for EXYNOS when it used to
> be used only on s5pv210, and it includes two samsung platform
> specific header files for historic reasons. Fortunately, it no
> longer actually needs them, so we can remove the #includes and
> avoid the problem
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: <linux-samsung-soc@vger.kernel.org>
> Cc: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
I checked that these machine specific headers are
unnecessary. Thanks!
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> Please apply on top of the other s5p-sss patches
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 47c568e..4197ad9 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -30,9 +30,6 @@
> #include <crypto/aes.h>
> #include <crypto/ctr.h>
>
> -#include <plat/cpu.h>
> -#include <mach/dma.h>
> -
> #define _SBF(s, v) ((v) << (s))
> #define _BIT(b) _SBF(b, 1)
>
>
> --
next prev parent reply other threads:[~2014-05-12 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 11:35 [PATCH] crypto: s5p-sss: fix multiplatform build Arnd Bergmann
2014-05-12 2:31 ` Jingoo Han [this message]
2014-05-13 11:45 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701cf6d8a$399b0990$acd11cb0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=arnd@arndb.de \
--cc=ch.naveen@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox