From: "Andrew.an" <bh74.an@samsung.com>
To: 'David Miller' <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
ilho215.lee@samsung.com
Subject: RE: [PATCH V2 RE-SEND 0/7] add new Samsung SXGbE driver
Date: Sat, 15 Mar 2014 17:23:17 -0700 [thread overview]
Message-ID: <000f01cf40ad$eecf0be0$cc6d23a0$@samsung.com> (raw)
In-Reply-To: <20140313.160947.1309757358549172711.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Byungho An <bh74.an@samsung.com>
> Date: Thu, 13 Mar 2014 15:55:28 +0900
>
> > This is 2nd posting for Samsung SXGbE driver and just re-sending because
> of
> > line wrapping in previous posting.
> >
> > Changes since v1:
> > - changed name of driver to SXGbE as per Ben's comment
> > - squashed Joe's neatening for many stuff in original patches
>
> I'm mostly happy with this driver, but all of those module parameters
> have to be removed except for 'debug'.
OK, I'll remove them.
>
> They duplicate functionality provided by ethtool.
OK.
>
> Module parameters are strongly, if not completely, discouraged. A
> suitable generic configuration mechanism, such as ethtool, should
> always be used instead.
OK. I'll repost soon.
Thanks
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-03-16 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 6:55 [PATCH V2 RE-SEND 0/7] add new Samsung SXGbE driver Byungho An
2014-03-13 20:09 ` David Miller
2014-03-16 0:23 ` Andrew.an [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01cf40ad$eecf0be0$cc6d23a0$@samsung.com' \
--to=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=ilho215.lee@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox