From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Dubey Subject: RE: [PATCH v3 0/2] Handle reboot for Exynos SoC via restart_handler Date: Mon, 10 Nov 2014 16:58:17 +0530 Message-ID: <000f01cffcd9$9f5dc860$de195920$@samsung.com> References: <1412668401-21837-1-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:38098 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbaKJL3b (ORCPT ); Mon, 10 Nov 2014 06:29:31 -0500 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NET009GAML56PC0@mailout4.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 10 Nov 2014 20:29:29 +0900 (KST) In-reply-to: <1412668401-21837-1-git-send-email-pankaj.dubey@samsung.com> Content-language: en-us Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: kgene.kim@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: tomasz.figa@gmail.com, linux@arm.linux.org.uk, thomas.ab@samsung.com, vikas.sajjan@samsung.com, linux@roeck-us.net, naushad@samsung.com Hi Kukjin, On Tuesday, October 07, 2014 1:23 PM, Pankaj Dubey wrote: > Subject: [PATCH v3 0/2] Handle reboot for Exynos SoC via restart_handler > > This patch removes restart hook from machine_desc of Exynos, and moves respective > code into reboot_notifiers. > Exynos5440 handles reboot via clock register so let's register a restart_handler in > Exynos5440 clock driver. > For rest Exynos SoC, reboot is handled via PMU SWRESET register so let's register a > restart_handler in PMU driver for handling this. > > This patch is inspired and dependent on following patch series[1] from Geunter > Roeck. > > Also this patch is dependent on PMU platform driver patch [2] by me, and has been > prepared on top of it. > > [1]: kernel: Add support for kernel restart handler call chain > https://lkml.org/lkml/2014/8/19/652 > > [2]: ARM: Exynos: Convert PMU implementation into a platform driver > https://lkml.org/lkml/2014/10/6/89 > > I have tested reboot functionality on Exynos3250 based board, on kgene/for-next as > well as linux-next's next-20140925 tag. > > Patch v2 and related discussion can be found here > http://www.spinics.net/lists/linux-samsung-soc/msg37457.html > > Changes since v2: > - Used register_restart_handler instead of register_reboot_notifier. > - Updated notifier names and commit message accordingly. > > Changes since v1: > - Addressed review comments from Tomasz Figa. Removed usage of > local variables where ever unnecessary. > - Make reg_base as global in clk-exynos5440.c file, to avoid > iomapping it again in reboot_notifier handler. > > Pankaj Dubey (2): > clk: samsung: exynos5440: move restart code into clock driver > ARM: EXYNOS: PMU: move restart code into pmu driver > > arch/arm/mach-exynos/common.h | 1 - > arch/arm/mach-exynos/exynos.c | 23 ----------------------- > arch/arm/mach-exynos/pmu.c | 24 > ++++++++++++++++++++++++ > drivers/clk/samsung/clk-exynos5440.c | 29 > ++++++++++++++++++++++++++++- > 4 files changed, 52 insertions(+), 25 deletions(-) > Will you please look into this patch series? > -- > 1.7.9.5