From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Marek Szyprowski' <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: kyungmin.park@samsung.com, ben-linux@fluff.org, jy0922.shim@samsung.com
Subject: RE: [PATCH 4/6] ARM: S5PC100: Move external interrupt defines
Date: Fri, 10 Sep 2010 21:00:20 +0900 [thread overview]
Message-ID: <001001cb50df$c0ed7e30$42c87a90$%kim@samsung.com> (raw)
In-Reply-To: <1283764347-460-5-git-send-email-m.szyprowski@samsung.com>
Marek Szyprowski wrote:
>
> From: Joonyoung Shim <jy0922.shim@samsung.com>
>
> This patch moves external interrupt defines from gpio.h to regs-gpio.h
> for consistency with s5pv210.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/mach-s5pc100/include/mach/gpio.h | 7 -------
> arch/arm/mach-s5pc100/include/mach/regs-gpio.h | 7 +++++++
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-s5pc100/include/mach/gpio.h b/arch/arm/mach-
> s5pc100/include/mach/gpio.h
> index 71ae1f5..29a8a12 100644
> --- a/arch/arm/mach-s5pc100/include/mach/gpio.h
> +++ b/arch/arm/mach-s5pc100/include/mach/gpio.h
> @@ -146,13 +146,6 @@ enum s5p_gpio_number {
> /* define the number of gpios we need to the one after the MP04() range
*/
> #define ARCH_NR_GPIOS (S5PC100_GPIO_END + 1)
>
> -#define EINT_MODE S3C_GPIO_SFN(0x2)
> -
> -#define EINT_GPIO_0(x) S5PC100_GPH0(x)
> -#define EINT_GPIO_1(x) S5PC100_GPH1(x)
> -#define EINT_GPIO_2(x) S5PC100_GPH2(x)
> -#define EINT_GPIO_3(x) S5PC100_GPH3(x)
> -
> #include <asm-generic/gpio.h>
>
> #endif /* __ASM_ARCH_GPIO_H */
> diff --git a/arch/arm/mach-s5pc100/include/mach/regs-gpio.h
b/arch/arm/mach-
> s5pc100/include/mach/regs-gpio.h
> index dd6295e..6abe481 100644
> --- a/arch/arm/mach-s5pc100/include/mach/regs-gpio.h
> +++ b/arch/arm/mach-s5pc100/include/mach/regs-gpio.h
> @@ -71,5 +71,12 @@
> #define S5P_EXTINT_RISEEDGE (0x03)
> #define S5P_EXTINT_BOTHEDGE (0x04)
>
> +#define EINT_MODE S3C_GPIO_SFN(0x2)
> +
> +#define EINT_GPIO_0(x) S5PC100_GPH0(x)
> +#define EINT_GPIO_1(x) S5PC100_GPH1(x)
> +#define EINT_GPIO_2(x) S5PC100_GPH2(x)
> +#define EINT_GPIO_3(x) S5PC100_GPH3(x)
> +
> #endif /* __ASM_MACH_S5PC100_REGS_GPIO_H */
>
> --
This is ok to me, will apply.
And will check other regarding gpio interrupt in this weekend ;-)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-09-10 12:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 9:12 [PATCH v3] ARM: S5P: Add support for gpio interrupts Marek Szyprowski
2010-09-06 9:12 ` [PATCH 1/6] ARM: Samsung: Add common s5p gpio interrupt support Marek Szyprowski
2010-09-28 14:03 ` Kukjin Kim
2010-09-28 14:24 ` Marek Szyprowski
2010-09-28 14:43 ` Kyungmin Park
2010-09-30 7:12 ` [PATCH v4] " Marek Szyprowski
2010-09-30 13:29 ` Kukjin Kim
2010-09-30 13:47 ` Kyungmin Park
2010-09-06 9:12 ` [PATCH 2/6] ARM: S5PC110: add support for gpio interrupts Marek Szyprowski
2010-09-06 9:12 ` [PATCH 3/6] ARM: S5PC100: Use generic S5P gpio interrupts interface Marek Szyprowski
2010-09-06 9:12 ` [PATCH 4/6] ARM: S5PC100: Move external interrupt defines Marek Szyprowski
2010-09-10 12:00 ` Kukjin Kim [this message]
2010-09-21 5:16 ` Marek Szyprowski
2010-09-06 9:12 ` [PATCH 5/6] ARM: Samsung: Add common samsung_gpiolib_to_irq function Marek Szyprowski
2010-10-01 4:49 ` Kukjin Kim
2010-10-01 5:19 ` Marek Szyprowski
2010-09-06 9:12 ` [PATCH 6/6] ARM: S5PC110: GONI: Add support for QT602240 TS driver Marek Szyprowski
2010-10-04 9:22 ` [PATCH RESEND] " Marek Szyprowski
2010-10-04 9:40 ` Kukjin Kim
2010-09-29 6:49 ` [PATCH v3] ARM: S5P: Add support for gpio interrupts Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001001cb50df$c0ed7e30$42c87a90$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox