From: Jingoo Han <jg1.han@samsung.com>
To: 'Vivek Gautam' <gautam.vivek@samsung.com>,
linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
gregkh@linuxfoundation.org, balbi@ti.com, kgene.kim@samsung.com,
k.debski@samsung.com, 'Alan Stern' <stern@rowland.harvard.edu>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH 1/4] usb: ohci-exynos: Use struct device instead of platform_device
Date: Mon, 28 Apr 2014 19:30:03 +0900 [thread overview]
Message-ID: <001801cf62cc$d1286690$737933b0$%han@samsung.com> (raw)
In-Reply-To: <1398677132-30600-2-git-send-email-gautam.vivek@samsung.com>
On Monday, April 28, 2014 6:25 PM, Vivek Gautam wrote:
>
> Change to use struct device instead of struct platform_device
> for some static functions.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> Cc: Alan Stern <stern@rowland.harvard.edu>
> ---
> drivers/usb/host/ohci-exynos.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
> index 9cf80cb..05f00e3 100644
> --- a/drivers/usb/host/ohci-exynos.c
> +++ b/drivers/usb/host/ohci-exynos.c
> @@ -39,18 +39,18 @@ struct exynos_ohci_hcd {
> struct usb_otg *otg;
> };
>
> -static void exynos_ohci_phy_enable(struct platform_device *pdev)
> +static void exynos_ohci_phy_enable(struct device *dev)
> {
> - struct usb_hcd *hcd = platform_get_drvdata(pdev);
> + struct usb_hcd *hcd = dev_get_drvdata(dev);
> struct exynos_ohci_hcd *exynos_ohci = to_exynos_ohci(hcd);
>
> if (exynos_ohci->phy)
> usb_phy_init(exynos_ohci->phy);
> }
>
> -static void exynos_ohci_phy_disable(struct platform_device *pdev)
> +static void exynos_ohci_phy_disable(struct device *dev)
> {
> - struct usb_hcd *hcd = platform_get_drvdata(pdev);
> + struct usb_hcd *hcd = dev_get_drvdata(dev);
> struct exynos_ohci_hcd *exynos_ohci = to_exynos_ohci(hcd);
>
> if (exynos_ohci->phy)
> @@ -139,7 +139,7 @@ skip_phy:
>
> platform_set_drvdata(pdev, hcd);
>
> - exynos_ohci_phy_enable(pdev);
> + exynos_ohci_phy_enable(&pdev->dev);
>
> err = usb_add_hcd(hcd, irq, IRQF_SHARED);
> if (err) {
> @@ -150,7 +150,7 @@ skip_phy:
> return 0;
>
> fail_add_hcd:
> - exynos_ohci_phy_disable(pdev);
> + exynos_ohci_phy_disable(&pdev->dev);
> fail_io:
> clk_disable_unprepare(exynos_ohci->clk);
> fail_clk:
> @@ -168,7 +168,7 @@ static int exynos_ohci_remove(struct platform_device *pdev)
> if (exynos_ohci->otg)
> exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self);
>
> - exynos_ohci_phy_disable(pdev);
> + exynos_ohci_phy_disable(&pdev->dev);
>
> clk_disable_unprepare(exynos_ohci->clk);
>
> @@ -190,7 +190,6 @@ static int exynos_ohci_suspend(struct device *dev)
> {
> struct usb_hcd *hcd = dev_get_drvdata(dev);
> struct exynos_ohci_hcd *exynos_ohci = to_exynos_ohci(hcd);
> - struct platform_device *pdev = to_platform_device(dev);
> bool do_wakeup = device_may_wakeup(dev);
> int rc = ohci_suspend(hcd, do_wakeup);
>
> @@ -200,7 +199,7 @@ static int exynos_ohci_suspend(struct device *dev)
> if (exynos_ohci->otg)
> exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self);
>
> - exynos_ohci_phy_disable(pdev);
> + exynos_ohci_phy_disable(dev);
>
> clk_disable_unprepare(exynos_ohci->clk);
>
> @@ -211,14 +210,13 @@ static int exynos_ohci_resume(struct device *dev)
> {
> struct usb_hcd *hcd = dev_get_drvdata(dev);
> struct exynos_ohci_hcd *exynos_ohci = to_exynos_ohci(hcd);
> - struct platform_device *pdev = to_platform_device(dev);
>
> clk_prepare_enable(exynos_ohci->clk);
>
> if (exynos_ohci->otg)
> exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self);
>
> - exynos_ohci_phy_enable(pdev);
> + exynos_ohci_phy_enable(dev);
>
> ohci_resume(hcd, false);
>
> --
> 1.7.10.4
next prev parent reply other threads:[~2014-04-28 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 9:25 [PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework Vivek Gautam
2014-04-28 9:25 ` [PATCH 1/4] usb: ohci-exynos: Use struct device instead of platform_device Vivek Gautam
2014-04-28 10:30 ` Jingoo Han [this message]
2014-04-28 9:25 ` [PATCH 2/4] usb: ehci-exynos: " Vivek Gautam
2014-04-28 10:30 ` Jingoo Han
2014-04-28 9:25 ` [PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework Vivek Gautam
2014-04-28 15:41 ` Alan Stern
2014-04-30 4:14 ` Vivek Gautam
[not found] ` <1398677132-30600-1-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-28 9:25 ` [PATCH v9 4/4] usb: ehci-exynos: Change " Vivek Gautam
2014-04-28 9:32 ` [PATCH v3 0/4] usb: ehci/ohci-exynos: Move to " Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001801cf62cc$d1286690$737933b0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.debski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox