From: Jungseok Lee <jays.lee@samsung.com>
To: 'Sachin Kamat' <sachin.kamat@linaro.org>
Cc: kgene.kim@samsung.com,
'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>
Subject: Re: ARM: EXYNOS: implement pm_power_off for EXYNOS5440
Date: Mon, 30 Sep 2013 07:49:38 +0900 [thread overview]
Message-ID: <002101cebd66$2d6487c0$882d9740$%lee@samsung.com> (raw)
In-Reply-To: <CAK9yfHwUrHoq5G37mRJ_20FfX+pR9kKFqVzqULE_M3=PoiHPkw@mail.gmail.com>
On Saturday, September 28, 2013 6:26 PM, Sachin Kamat wrote:
> On 28 September 2013 10:37, Jungseok Lee <jays.lee@samsung.com> wrote:
> >
> > +static void exynos5440_power_off(void)
> > +{
> > + struct device_node *np;
> > + void __iomem *addr;
> > +
> > + np = of_find_compatible_node(NULL, NULL, "samsung,exynos5440-clock");
> > +
> > + addr = of_iomap(np, 0) + 0x14;
> > +
> > + __raw_writel(0x1, addr);
>
> Probably the magic numbers could be defined as macros or atleast a
> comment to that effect would be useful.
Thanks for your suggestion.
I will add some comments on magic numbers and resend a patch.
(I've also missed [PATCH] at mail title.)
Best Regards
Jungseok Lee
prev parent reply other threads:[~2013-09-29 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 5:07 ARM: EXYNOS: implement pm_power_off for EXYNOS5440 Jungseok Lee
2013-09-28 9:25 ` Sachin Kamat
2013-09-29 22:49 ` Jungseok Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002101cebd66$2d6487c0$882d9740$%lee@samsung.com' \
--to=jays.lee@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox