From: Jonghun Han <jonghun.han@samsung.com>
To: 'Kamil Debski' <k.debski@samsung.com>,
'Jeongtae Park' <jtp.park@samsung.com>,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: jaeryul.oh@samsung.com
Subject: RE: [PATCH 7/9] media: MFC: Add MFC v5.1 V4L2 driver
Date: Fri, 07 Jan 2011 09:51:13 +0900 [thread overview]
Message-ID: <002601cbae05$010deb30$0329c190$%han@samsung.com> (raw)
In-Reply-To: <000c01cbacef$97e5c490$c7b14db0$%debski@samsung.com>
Hi Kamil,
Kamil Debski wrote:
> Hi,
>
> Thanks for the comment. Some of them include my code, which will I comment
> below.
>
> > My review also imply Kamil's original patch.
>
<snip>
> >
> > > +#define MFC_NUM_CONTEXTS 4
> >
> > How about use MFC_NUM_INSTANT instead MFC_NUM_CONTEXTS ?
> > Because too many terms can make confusion.
>
> An instance means an MFC HW instance. Context is used for each open file
handle.
I know that. But as I know each handle can have only single MFC H/W
instance.
So I wish to reduce the terms. Is there anything I missed ?
<snip>
> >
> > What's the difference btw num and inst_no ?
> > It looks very similar.
>
> The inst_no is the number of hardware instance in MFC. Num on the other
hand is
> the number of context used by an open file handle.
The inst_no made by MFC H/W has the same rule with num made by your code.
So in my opinion it is always the same. How do you think about that ?
<snip>
>
> Best wishes,
> --
> Kamil Debski
> Linux Platform Group
> Samsung Poland R&D Center
next prev parent reply other threads:[~2011-01-07 0:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 11:54 [PATCH 0/9] Multi Format Codec 5.1 driver for S5PC210 SoC Jeongtae Park
2010-12-22 11:54 ` [PATCH 1/9] media: Changes in include/linux/videodev2.h for MFC 5.1 Jeongtae Park
2010-12-22 11:54 ` [PATCH 2/9] ARM: S5PV310: Add clock support for MFC v5.1 Jeongtae Park
2010-12-22 11:54 ` [PATCH 3/9] ARM: S5PV310: Add memory map " Jeongtae Park
2010-12-22 11:54 ` [PATCH 4/9] ARM: S5P: Add platform " Jeongtae Park
2010-12-22 11:54 ` [PATCH 5/9] ARM: S5PV310: Add CMA support for MFC v5.1 on SMDKC210 Jeongtae Park
2010-12-22 11:54 ` [PATCH 6/9] ARM: S5PV310: Add CMA support for MFC v5.1 on SMDKV310 Jeongtae Park
2010-12-22 11:54 ` [PATCH 7/9] media: MFC: Add MFC v5.1 V4L2 driver Jeongtae Park
2010-12-22 11:54 ` [PATCH 8/9] ARM: S5PV310: Add MFC v5.1 platform device support for SMDKC210 Jeongtae Park
2010-12-22 11:54 ` [PATCH 9/9] ARM: S5PV310: Add MFC v5.1 platform device support for SMDKV310 Jeongtae Park
2010-12-22 13:01 ` [PATCH 7/9] media: MFC: Add MFC v5.1 V4L2 driver Hans Verkuil
2010-12-31 10:20 ` Kamil Debski
2010-12-22 13:08 ` Marek Szyprowski
2010-12-27 8:13 ` Jonghun Han
2011-01-05 15:45 ` Kamil Debski
2011-01-07 0:51 ` Jonghun Han [this message]
2010-12-22 12:42 ` [PATCH 1/9] media: Changes in include/linux/videodev2.h for MFC 5.1 Hans Verkuil
2010-12-27 16:27 ` Kamil Debski
2010-12-28 8:24 ` Jaeryul Oh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002601cbae05$010deb30$0329c190$%han@samsung.com' \
--to=jonghun.han@samsung.com \
--cc=jaeryul.oh@samsung.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox