From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH V2 2/2] spi: s3c64xx: fix checkpatch error and warnings
Date: Tue, 16 Jul 2013 08:23:41 +0900
Message-ID: <002e01ce81b2$5825d800$08718800$@samsung.com>
References: <000101ce8122$3621f7b0$a265e710$@samsung.com>
 <1373890206.2062.4.camel@joe-AO722>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <linux-samsung-soc-owner@vger.kernel.org>
Received: from mailout4.samsung.com ([203.254.224.34]:51725 "EHLO
	mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755797Ab3GOXXo (ORCPT
	<rfc822;linux-samsung-soc@vger.kernel.org>);
	Mon, 15 Jul 2013 19:23:44 -0400
In-reply-to: <1373890206.2062.4.camel@joe-AO722>
Content-language: ko
Sender: linux-samsung-soc-owner@vger.kernel.org
List-Id: linux-samsung-soc@vger.kernel.org
To: 'Joe Perches' <joe@perches.com>
Cc: 'Mark Brown' <broonie@kernel.org>, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>

On Monday, July 15, 2013 9:10 PM, Joe Perches wrote:
> On Mon, 2013-07-15 at 15:11 +0900, Jingoo Han wrote:
> []
> > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> []
> > @@ -338,8 +338,10 @@ static int acquire_dma(struct s3c64xx_spi_driver_data *sdd)
> []
> > -	sdd->rx_dma.ch = (void *)sdd->ops->request(sdd->rx_dma.dmach, &req, dev, "rx");
> > -	sdd->tx_dma.ch = (void *)sdd->ops->request(sdd->tx_dma.dmach, &req, dev, "tx");
> > +	sdd->rx_dma.ch = (void *)sdd->ops->request(sdd->rx_dma.dmach,
> > +						&req, dev, "rx");
> > +	sdd->tx_dma.ch = (void *)sdd->ops->request(sdd->tx_dma.dmach,
> > +						&req, dev, "tx");
> 
> There should be sparse errors here.
> sdd->ops->request is unsigned int, not unsigned long.
> Care to fix the cast of unsigned to pointer too?

OK, I will fix it as below:

sdd->rx_dma.ch = (unsigned long *)sdd->ops->request(sdd->rx_dma.dmach,
							&req, dev, "rx");
sdd->tx_dma.ch = (unsigned long *)sdd->ops->request(sdd->tx_dma.dmach,
							&req, dev, "tx");

> 
> > @@ -439,7 +441,7 @@ static int s3c64xx_spi_prepare_transfer(struct spi_master *spi)
> >
> >  	/* Acquire DMA channels */
> >  	sdd->rx_dma.ch = dma_request_slave_channel_compat(mask, filter,
> > -				(void*)sdd->rx_dma.dmach, dev, "rx");
> > +				(void *)sdd->rx_dma.dmach, dev, "rx");
> 
> It seems unsigned to pointer conversions are pretty
> rampant in this code.

It seems so.
I will look into it, later.

Thank you for your feedback.

Best regards,
Jingoo Han