RE: [PATCH 1/6] ARM: S5PC110: update framebuffer setup information for Goni

[Marek Szyprowski <m.szyprowski@samsung.com>]

Hello,

On Friday, September 10, 2010 11:50 AM Kukjin Kim wrote:

> Marek Szyprowski wrote:
> >
> > Change the default upper_margin and vsync_len to get rid of repeated last
> > line on the display.
> >
> How about Aquila board? Maybe same in my thinking.

Yes, I will send a similar patch once I do a test. Had no access to Aquila
board that time.

> And it'd better that another stuff like removing pixclock is in different
> patch.

Well, Goni machine was the last one that had pixelclock defined. All other
boards had pixel clock definition already removed, so I thought that it would
be a good opportunity to fix this together with screen definition update.
 
> Anyway, looks ok to me...will apply.

Thx

> 
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >  arch/arm/mach-s5pv210/mach-goni.c |    5 ++---
> >  1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-s5pv210/mach-goni.c
> b/arch/arm/mach-s5pv210/mach-
> > goni.c
> > index d9fe739..b0ae208 100644
> > --- a/arch/arm/mach-s5pv210/mach-goni.c
> > +++ b/arch/arm/mach-s5pv210/mach-goni.c
> > @@ -88,13 +88,12 @@ static struct s3c2410_uartcfg goni_uartcfgs[]
> __initdata = {
> >  /* Frame Buffer */
> >  static struct s3c_fb_pd_win goni_fb_win0 = {
> >  	.win_mode = {
> > -		.pixclock = 1000000000000ULL /
> > ((16+16+2+480)*(28+3+2+800)*55),
> >  		.left_margin	= 16,
> >  		.right_margin	= 16,
> > -		.upper_margin	= 3,
> > +		.upper_margin	= 2,
> >  		.lower_margin	= 28,
> >  		.hsync_len	= 2,
> > -		.vsync_len	= 2,
> > +		.vsync_len	= 1,
> >  		.xres		= 480,
> >  		.yres		= 800,
> >  		.refresh	= 55,
> > --
> > 1.7.2.2
> 

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center