From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Russell King - ARM Linux' <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Subject: RE: [PATCH 13/24] ARM: s5pv310: update clock source registration
Date: Fri, 17 Dec 2010 13:49:39 +0900 [thread overview]
Message-ID: <002f01cb9da5$d30eac70$792c0550$%kim@samsung.com> (raw)
In-Reply-To: <E1PSDvg-0008D8-6F@rmk-PC.arm.linux.org.uk>
Russell King wrote:
>
> In d7e81c2 (clocksource: Add clocksource_register_hz/khz interface) new
> interfaces were added which simplify (and optimize) the selection of the
> divisor shift/mult constants. Switch over to using this new interface.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/mach-s5pv310/time.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv310/time.c b/arch/arm/mach-s5pv310/time.c
> index 01b012a..b262d46 100644
> --- a/arch/arm/mach-s5pv310/time.c
> +++ b/arch/arm/mach-s5pv310/time.c
> @@ -211,7 +211,6 @@ struct clocksource pwm_clocksource = {
> .rating = 250,
> .read = s5pv310_pwm4_read,
> .mask = CLOCKSOURCE_MASK(32),
> - .shift = 20,
> .flags = CLOCK_SOURCE_IS_CONTINUOUS ,
> };
>
> @@ -230,10 +229,7 @@ static void __init s5pv310_clocksource_init(void)
> s5pv310_pwm_init(4, ~0);
> s5pv310_pwm_start(4, 1);
>
> - pwm_clocksource.mult =
> - clocksource_khz2mult(clock_rate/1000,
pwm_clocksource.shift);
> -
> - if (clocksource_register(&pwm_clocksource))
> + if (clocksource_register_hz(&pwm_clocksource, clock_rate))
> panic("%s: can't register clocksource\n",
> pwm_clocksource.name);
> }
>
> --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2010-12-17 4:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 19:14 [PATCH 0/24] Update clocksource registration Russell King - ARM Linux
2010-12-13 19:19 ` [PATCH 13/24] ARM: s5pv310: update clock source registration Russell King - ARM Linux
2010-12-17 4:49 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01cb9da5$d30eac70$792c0550$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox