From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pawel Osciak Subject: RE: [PATCH v3 5/8] ARM: s5pv210: enable FIMC on Aquila Date: Mon, 26 Jul 2010 08:51:36 +0200 Message-ID: <003201cb2c8e$fdf0dc70$f9d29550$%osciak@samsung.com> References: <1279902083-21250-1-git-send-email-s.nawrocki@samsung.com> <1279902083-21250-6-git-send-email-s.nawrocki@samsung.com> <00b801cb2c8d$98282610$c8787230$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:36379 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752832Ab0GZGxI (ORCPT ); Mon, 26 Jul 2010 02:53:08 -0400 Received: from eu_spt1 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0L6500EQ5KGHGZ@mailout1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 26 Jul 2010 07:53:05 +0100 (BST) Received: from linux.samsung.com ([106.116.38.10]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0L6500MUCKGHXD@spt1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 26 Jul 2010 07:53:05 +0100 (BST) In-reply-to: <00b801cb2c8d$98282610$c8787230$%kim@samsung.com> Content-language: pl Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Kukjin Kim' , Sylwester Nawrocki , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Marek Szyprowski , kyungmin.park@samsung.com Hello, >Kukjin Kim wrote: >Sylwester Nawrocki wrote: >> >> Add support for FIMC on Samsung Aquila board. >> >> Signed-off-by: Sylwester Nawrocki >> Signed-off-by: Kyungmin Park >> Signed-off-by: Marek Szyprowski >> --- >> arch/arm/mach-s5pv210/Kconfig | 4 ++++ >> arch/arm/mach-s5pv210/mach-aquila.c | 7 +++++++ >> 2 files changed, 11 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig >> index 039ba8c..b81b91b 100644 >> --- a/arch/arm/mach-s5pv210/Kconfig >> +++ b/arch/arm/mach-s5pv210/Kconfig >> @@ -58,9 +58,13 @@ menu "S5PC110 Machines" >> config MACH_AQUILA >> bool "Aquila" >> select CPU_S5PV210 >> + select COMMON_AQUILA_GONI > >... > Please see my previous comments. >> select ARCH_SPARSEMEM_ENABLE >> select S5PV210_SETUP_FB_24BPP >> select S3C_DEV_FB >> + select S5P_DEV_FIMC0 >> + select S5P_DEV_FIMC1 >> + select S5P_DEV_FIMC2 >> select S5PC110_DEV_ONENAND >> help >> Machine support for the Samsung Aquila target based on S5PC110 >> SoC >> diff --git a/arch/arm/mach-s5pv210/mach-aquila.c >b/arch/arm/mach-s5pv210/mach- >> aquila.c >> index 0992618..7528514 100644 >> --- a/arch/arm/mach-s5pv210/mach-aquila.c >> +++ b/arch/arm/mach-s5pv210/mach-aquila.c >> @@ -35,6 +35,9 @@ >> #include >> #include >> #include >> +#include >> + >> +#include "common-aquila-goni.h" > >Hmm...please refer to my another comment. > Ditto. >> >> /* Following are default values for UCON, ULCON and UFCON UART registers >*/ >> #define S5PV210_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | \ >> @@ -445,6 +448,9 @@ static struct platform_device *aquila_devices[] >__initdata = >> { >> &aquila_device_gpiokeys, >> &s3c_device_fb, >> &s5pc110_device_onenand, >> + &s5p_device_fimc0, >> + &s5p_device_fimc1, >> + &s5p_device_fimc2, >> }; >> >> static void __init aquila_map_io(void) >> @@ -465,6 +471,7 @@ static void __init aquila_machine_init(void) >> s3c_fb_set_platdata(&aquila_lcd_pdata); >> >> platform_add_devices(aquila_devices, ARRAY_SIZE(aquila_devices)); >> + s5pv210_common_fimc_clk_init(); > >Hmm...really need this fimc_clk_init here not driver? > I believe that the whole idea is that drivers should not be involved in clocks setup, especially in setting up source parameters... Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center