Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Marek Szyprowski' <m.szyprowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: kyungmin.park@samsung.com, ben-linux@fluff.org
Subject: RE: [PATCHv2 1/7] ARM: S5PC110: update framebuffer setup information for Goni
Date: Tue, 28 Sep 2010 16:07:29 +0900	[thread overview]
Message-ID: <005801cb5edb$d46579e0$7d306da0$%kim@samsung.com> (raw)
In-Reply-To: <1284987337-15365-2-git-send-email-m.szyprowski@samsung.com>

Marek Szyprowski wrote:
> 
> Change the default upper_margin and vsync_len to get rid of repeated last
> line on the display.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/mach-s5pv210/mach-goni.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c
b/arch/arm/mach-s5pv210/mach-
> goni.c
> index d9fe739..4bd5582 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -91,10 +91,10 @@ static struct s3c_fb_pd_win goni_fb_win0 = {
>  		.pixclock = 1000000000000ULL /
> ((16+16+2+480)*(28+3+2+800)*55),
>  		.left_margin	= 16,
>  		.right_margin	= 16,
> -		.upper_margin	= 3,
> +		.upper_margin	= 2,
>  		.lower_margin	= 28,
>  		.hsync_len	= 2,
> -		.vsync_len	= 2,
> +		.vsync_len	= 1,
>  		.xres		= 480,
>  		.yres		= 800,
>  		.refresh	= 55,
> --

This is better than your previous patch to me.

Will apply.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2010-09-28  7:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20 12:55 [PATCH v2] ARM: S5PC110: Samsung Goni board update Marek Szyprowski
2010-09-20 12:55 ` [PATCHv2 1/7] ARM: S5PC110: update framebuffer setup information for Goni Marek Szyprowski
2010-09-28  7:07   ` Kukjin Kim [this message]
2010-09-20 12:55 ` [PATCHv2 2/7] ARM: S5PC110: fb setup for Goni - remove pixel clock Marek Szyprowski
2010-09-28  7:08   ` Kukjin Kim
2010-09-20 12:55 ` [PATCHv2 3/7] ARM: S5PC110: add support for S6E63M0 LCD controller on Goni board Marek Szyprowski
2010-09-28  7:38   ` Kukjin Kim
2010-09-28 12:27     ` Marek Szyprowski
2010-09-28 13:15     ` [PATCH v3] " Marek Szyprowski
2010-10-02 10:40       ` Kukjin Kim
2010-10-04  5:42         ` Marek Szyprowski
2010-09-20 12:55 ` [PATCHv2 4/7] ARM: S5PC110: Add si470x radio device to the GONI board Marek Szyprowski
2010-09-28  7:43   ` Kukjin Kim
2010-09-28 13:08     ` Marek Szyprowski
2010-09-28 14:04       ` Kukjin Kim
2010-09-29  5:28         ` Marek Szyprowski
2010-09-20 12:55 ` [PATCHv2 5/7] ARM: S5PV210: Enable USB HSOTG gadget build Marek Szyprowski
2010-09-28  7:53   ` Kukjin Kim
2010-09-20 12:55 ` [PATCHv2 6/7] ARM: S5PC110: add support for otg usb gadget on Goni board Marek Szyprowski
2010-09-28  7:54   ` Kukjin Kim
2010-09-20 12:55 ` [PATCHv2 7/7] ARM: S5PC110: add support for MMC regulators " Marek Szyprowski
2010-09-20 13:03   ` Mark Brown
2010-09-28  6:27   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005801cb5edb$d46579e0$7d306da0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox