From: Pavel Fedin <p.fedin@samsung.com>
To: 'Krzysztof Kozlowski' <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: 'Kukjin Kim' <kgene@kernel.org>,
'Pankaj Dubey' <pankaj.dubey@samsung.com>
Subject: RE: [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration
Date: Thu, 29 Oct 2015 09:54:01 +0300 [thread overview]
Message-ID: <006b01d11216$9831dc40$c89594c0$@samsung.com> (raw)
In-Reply-To: <56318175.6000006@samsung.com>
Hello!
> > + for_each_child_of_node(np, child)
> > + decode_sromc(srom, child);
>
> You ignore the return value here so bank may be not configured but
> device probe will return 0.
Yes, so that banks which are described correctly, will still be configured.
> Maybe clean up and fail the probe?
I think it's not fatal, so cleanup is not necessary. May be dev_warn() in this case?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-29 6:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 7:57 [PATCH v3 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-10-29 2:27 ` Krzysztof Kozlowski
2015-10-29 7:45 ` Pavel Fedin
2015-10-29 10:29 ` Krzysztof Kozlowski
2015-10-29 11:43 ` Pavel Fedin
2015-10-30 6:09 ` Krzysztof Kozlowski
2015-10-28 7:57 ` [PATCH v3 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-10-29 2:16 ` Krzysztof Kozlowski
2015-10-29 6:54 ` Pavel Fedin [this message]
2015-10-29 6:59 ` Krzysztof Kozlowski
2015-10-29 8:17 ` Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006b01d11216$9831dc40$c89594c0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox