RE: [PATCH 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

[Kukjin Kim <kgene.kim@samsung.com>]

Kyungmin Park wrote:
> 
> On Fri, Jul 16, 2010 at 10:13 PM, Kukjin Kim <kgene.kim@samsung.com>
wrote:
> > From: Naveen Krishna Ch <ch.naveen@samsung.com>
> >
> > This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and
> S5P6440.
> >
> > Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> >  drivers/i2c/busses/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index bceafbf..e553fe8 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -523,7 +523,7 @@ config I2C_PXA_SLAVE
> >
> >  config I2C_S3C2410
> >        tristate "S3C2410 I2C Driver"
> > -       depends on ARCH_S3C2410 || ARCH_S3C64XX
> > +       depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5PV210 ||
> ARCH_S5P6440
> 
> Are there any SoCs don't have i2c? If no, how about to just depends on
> PLAT_SAMSUNG.
> 
I thought about this again, but I'm not sure your suggestion is better.
Because as you said, there is no Samsung SoC that does not have
I2C...however it's true that this I2C driver cannot support/(is not tested
on) every Samsung SoCs now.

So, to add available SoC ARCH is better to us at the present.

> Thank you,
> Kyungmin Park
> >        help
> >          Say Y here to include support for I2C controller in the
> >          Samsung S3C2410 based System-on-Chip devices.

Just need to modify help message...



Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.