From: Pavel Fedin <p.fedin@samsung.com>
To: 'Krzysztof Kozlowski' <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: 'Kukjin Kim' <kgene@kernel.org>,
'Pankaj Dubey' <pankaj.dubey@samsung.com>
Subject: RE: [PATCH v2 1/4] ARM: dts: Add SROMc to Exynos 5410
Date: Wed, 28 Oct 2015 10:06:57 +0300 [thread overview]
Message-ID: <009001d1114f$3c7a1f60$b56e5e20$@samsung.com> (raw)
In-Reply-To: <56302F1F.5090206@samsung.com>
Hello!
> > + sromc: sromc@12250000 {
> > + compatible = "samsung,exynos-srom";
> > + reg = <0x12250000 0x10>;
>
> Isn't 0x10 too small (SROM_BC3 won't be mapped)?
Muhaha, indeed, thanks for noticing this.
By the way, i've just checked exynos4.dtsi and exynos5.dtsi, they specify the same size. Did reviewers overlook this small thing?
Shouldn't it be fixed then?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-28 7:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 8:43 [PATCH v2 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-10-27 8:43 ` [PATCH v2 1/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-10-28 2:12 ` Krzysztof Kozlowski
2015-10-28 7:06 ` Pavel Fedin [this message]
2015-10-28 7:24 ` Krzysztof Kozlowski
2015-10-28 7:25 ` Pavel Fedin
2015-10-28 9:30 ` Pankaj Dubey
2015-10-28 9:36 ` Krzysztof Kozlowski
2015-10-28 9:39 ` Pavel Fedin
2015-10-27 8:43 ` [PATCH v2 2/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-10-27 8:43 ` [PATCH v2 3/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
2015-10-27 8:43 ` [PATCH v2 4/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-10-28 1:52 ` [PATCH v2 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009001d1114f$3c7a1f60$b56e5e20$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox