From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Daniel Lezcano' <daniel.lezcano@linaro.org>
Cc: 'amit daniel kachhap' <amit.daniel@samsung.com>,
linux-samsung-soc@vger.kernel.org, linaro-dev@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, patches@linaro.org
Subject: RE: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up
Date: Thu, 17 Jan 2013 19:51:31 -0800 [thread overview]
Message-ID: <00be01cdf52f$1bc907c0$535b1740$@samsung.com> (raw)
In-Reply-To: <50F551F3.2060400@linaro.org>
Daniel Lezcano wrote:
>
> On 01/10/2013 11:33 PM, amit daniel kachhap wrote:
> > On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano <daniel.lezcano@free.fr>
> wrote:
> >> On 01/10/2013 09:07 PM, amit daniel kachhap wrote:
> >>> Hi Daniel,
> >>
> >> Hi Amit Daniel,
> >>
> >>> This hotplug noifiers looks fine. I suppose it should add extra state
> >>> C1 in cpu0. If it is done like below than for normal cases(when all
> >>> cpu's are online) there wont be any statistics for C0 state
> >>
> >> I guess you meant state 0 which is WFI, right ?
> >> C0 state is the intel semantic for cpu fully turned on.
> > Yes I meant C0 as wfi
> >>
> >>> also which
> >>> is required. Other patches look good.
> >>
> >> Ok, that makes sense to have statistics even if they are only doing WFI.
> >>
> >> Then the patch 4/5 is not ok, no ?
> > yes I suppose patch 4 and patch 5 are related and depends how you
> > frame patch 5. I think it is better to create C0/C1 sysfs and other
> > things in the beginning because it is a filesystem call and may
> > increase the cpu hotplug time which is not worth. May be if cpuidle
> > framework exposes some API to enable/disable states then it is better.
> >
> > For patch 1,2 and 3,
> > Acked-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
>
> Hi Kukjin,
>
> is it possible to take these patches [1-3/5] ?
>
Looks OK to me, I will apply with Amit's ack.
> The patches [3-4/5] could be ignored.
>
Probably, you mean [4-5/5] :-)
Thanks.
- Kukjin
next prev parent reply other threads:[~2013-01-18 3:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 16:59 [PATCH 1/5] ARM: exynos: factor out the idle states Daniel Lezcano
[not found] ` <1357318799-24378-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-01-04 16:59 ` [PATCH 2/5] ARM: exynos: handle properly the return values Daniel Lezcano
2013-01-04 16:59 ` [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up Daniel Lezcano
2013-01-10 20:07 ` amit daniel kachhap
2013-01-10 21:32 ` Daniel Lezcano
2013-01-10 22:33 ` amit daniel kachhap
2013-01-15 12:56 ` Daniel Lezcano
2013-01-18 3:51 ` Kukjin Kim [this message]
2013-01-18 8:18 ` Daniel Lezcano
2013-01-04 16:59 ` [PATCH 3/5] ARM: exynos: replace cpumask by the corresponding macro Daniel Lezcano
2013-01-04 16:59 ` [PATCH 4/5] ARM: exynos: only register cpuidle for cpu0 Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00be01cdf52f$1bc907c0$535b1740$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=amit.daniel@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox