From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH v4 3/8] ARM: Samsung: Add platform definitions and helpers for FIMC driver Date: Tue, 03 Aug 2010 09:46:38 +0900 Message-ID: <00e501cb32a5$5775ed50$0661c7f0$%kim@samsung.com> References: <1279902083-21250-4-git-send-email-s.nawrocki@samsung.com> <1280750229-15732-1-git-send-email-m.szyprowski@samsung.com> <00e101cb329e$a50ceb60$ef26c220$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:61880 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752930Ab0HCAqc convert rfc822-to-8bit (ORCPT ); Mon, 2 Aug 2010 20:46:32 -0400 Received: from epmmp1 (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Sun Java(tm) System Messaging Server 7u3-15.01 64bit (built Feb 12 2010)) with ESMTP id <0L6J00FMHWTIWX20@mailout2.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 03 Aug 2010 09:46:30 +0900 (KST) Received: from kgenekim ([12.23.103.96]) by mmp1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0L6J00EYAWTH70@mmp1.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 03 Aug 2010 09:46:30 +0900 (KST) In-reply-to: Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Kyungmin Park' Cc: 'Marek Szyprowski' , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, s.nawrocki@samsung.com, p.osciak@samsung.com, ben-linux@fluff.org Kyungmin Park wrote: >=20 > On Tue, Aug 3, 2010 at 8:58 AM, Kukjin Kim wr= ote: > > Marek Szyprowski wrote: > >> > >> From: Sylwester Nawrocki > >> > >> FIMC (CAMIF) device is a camera interface embedded in S3C/S5P Sams= ung > >> SOC series. It supports ITU-R BT.601/656 and MIPI-CSI2 standards, > >> memory to memory operations, color conversion, resizing and rotati= on. > >> > >> Signed-off-by: Sylwester Nawrocki > >> Signed-off-by: Kyungmin Park > >> Signed-off-by: Marek Szyprowski > >> --- > >> > >> This is patch is a v3 version rebased onto latest kgene/for-next t= ree. > >> New entries in map.h files has been sorted by the physicall addres= s. > >> > > Thanks for your addressing. > > > >> I'm resending this patch on behalf of Sylwester who is on holidays= this > >> week. > >> > >> Best regards > >> -- > >> Marek Szyprowski > >> Samsung Poland R&D Center > >> --- > >> =A0arch/arm/mach-s5pc100/include/mach/map.h =A0 =A0 =A0 | =A0 =A07= ++++ > >> =A0arch/arm/mach-s5pv210/cpu.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0| =A0 =A05 +++ > >> =A0arch/arm/mach-s5pv210/include/mach/map.h =A0 =A0 =A0 | =A0 =A08= ++++ > >> =A0arch/arm/plat-s5p/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0| =A0 16 ++++++++ > >> =A0arch/arm/plat-s5p/Makefile =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 | =A0 =A03 ++ > >> =A0arch/arm/plat-s5p/dev-fimc0.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= | =A0 35 > >> ++++++++++++++++++ > >> =A0arch/arm/plat-s5p/dev-fimc1.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= | =A0 35 > >> ++++++++++++++++++ > >> =A0arch/arm/plat-s5p/dev-fimc2.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= | =A0 35 > >> ++++++++++++++++++ > >> =A0arch/arm/plat-samsung/include/plat/fimc-core.h | =A0 45 > >> ++++++++++++++++++++++++ > >> =A0arch/arm/plat-samsung/include/plat/fimc.h =A0 =A0 =A0| =A0 22 += ++++++++++ > >> =A010 files changed, 211 insertions(+), 0 deletions(-) > >> =A0create mode 100644 arch/arm/plat-s5p/dev-fimc0.c > >> =A0create mode 100644 arch/arm/plat-s5p/dev-fimc1.c > >> =A0create mode 100644 arch/arm/plat-s5p/dev-fimc2.c > >> =A0create mode 100644 arch/arm/plat-samsung/include/plat/fimc-core= =2Eh > >> =A0create mode 100644 arch/arm/plat-samsung/include/plat/fimc.h > >> > >> diff --git a/arch/arm/mach-s5pc100/include/mach/map.h b/arch/arm/m= ach- > >> s5pc100/include/mach/map.h > >> index c018697..3abe7f5 100644 > >> --- a/arch/arm/mach-s5pc100/include/mach/map.h > >> +++ b/arch/arm/mach-s5pc100/include/mach/map.h > >> @@ -99,6 +99,10 @@ > >> > >> =A0#define S5PC100_PA_FB =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(0xEE00000= 0) > >> > >> +#define S5PC100_PA_FIMC0 =A0 =A0 (0xEE200000) > >> +#define S5PC100_PA_FIMC1 =A0 =A0 (0xEE300000) > >> +#define S5PC100_PA_FIMC2 =A0 =A0 (0xEE400000) > >> + > >> =A0#define S5PC100_PA_I2S0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(0xF2000000) > >> =A0#define S5PC100_PA_I2S1 =A0 =A0 =A0 =A0 =A0 =A0 =A0(0xF2100000) > >> =A0#define S5PC100_PA_I2S2 =A0 =A0 =A0 =A0 =A0 =A0 =A0(0xF2200000) > >> @@ -143,6 +147,9 @@ > >> =A0#define S3C_PA_ONENAND_BUF =A0 S5PC100_PA_ONENAND_BUF > >> =A0#define S3C_SZ_ONENAND_BUF =A0 S5PC100_SZ_ONENAND_BUF > >> =A0#define S3C_PA_RTC =A0 =A0 =A0 =A0 =A0 S5PC100_PA_RTC > >> +#define S5P_PA_FIMC0 =A0 =A0 =A0 =A0 S5PC100_PA_FIMC0 > >> +#define S5P_PA_FIMC1 =A0 =A0 =A0 =A0 S5PC100_PA_FIMC1 > >> +#define S5P_PA_FIMC2 =A0 =A0 =A0 =A0 S5PC100_PA_FIMC2 > >> > >> =A0#define SAMSUNG_PA_ADC =A0 =A0 =A0 =A0 =A0 =A0 =A0 S5PC100_PA_T= SADC > >> =A0#define SAMSUNG_PA_CFCON =A0 =A0 S5PC100_PA_CFCON > >> diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/c= pu.c > >> index ea09c32..a7446d4 100644 > >> --- a/arch/arm/mach-s5pv210/cpu.c > >> +++ b/arch/arm/mach-s5pv210/cpu.c > >> @@ -37,6 +37,7 @@ > >> =A0#include > >> =A0#include > >> =A0#include > >> +#include > >> =A0#include > >> > >> =A0/* Initial IO mappings */ > >> @@ -104,6 +105,10 @@ void __init s5pv210_map_io(void) > >> > >> =A0 =A0 =A0 /* Use s5pv210-keypad instead of samsung-keypad */ > >> =A0 =A0 =A0 samsung_keypad_setname("s5pv210-keypad"); > >> + > >> + =A0 =A0 s3c_fimc_setname(0, "s5pv210-fimc"); > >> + =A0 =A0 s3c_fimc_setname(1, "s5pv210-fimc"); > >> + =A0 =A0 s3c_fimc_setname(2, "s5pv210-fimc"); > >> =A0} > >> > >> =A0void __init s5pv210_init_clocks(int xtal) > >> diff --git a/arch/arm/mach-s5pv210/include/mach/map.h b/arch/arm/m= ach- > >> s5pv210/include/mach/map.h > >> index 986b285..6a07e55 100644 > >> --- a/arch/arm/mach-s5pv210/include/mach/map.h > >> +++ b/arch/arm/mach-s5pv210/include/mach/map.h > >> @@ -65,6 +65,10 @@ > >> > >> =A0#define S5PV210_PA_FB =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(0xF800000= 0) > >> > >> +#define S5PV210_PA_FIMC0 =A0 =A0 (0xFB200000) > >> +#define S5PV210_PA_FIMC1 =A0 =A0 (0xFB300000) > >> +#define S5PV210_PA_FIMC2 =A0 =A0 (0xFB400000) > >> + > >> =A0#define S5PV210_PA_HSMMC(x) =A0(0xEB000000 + ((x) * 0x100000)) > >> > >> =A0#define S5PV210_PA_VIC0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(0xF2000000) > >> @@ -114,4 +118,8 @@ > >> =A0#define SAMSUNG_PA_CFCON =A0 =A0 S5PV210_PA_CFCON > >> =A0#define SAMSUNG_PA_KEYPAD =A0 =A0S5PV210_PA_KEYPAD > >> > >> +#define S5P_PA_FIMC0 =A0 =A0 =A0 =A0 S5PV210_PA_FIMC0 > >> +#define S5P_PA_FIMC1 =A0 =A0 =A0 =A0 S5PV210_PA_FIMC1 > >> +#define S5P_PA_FIMC2 =A0 =A0 =A0 =A0 S5PV210_PA_FIMC2 > > > > To use one style is better for reading, merge conflict handling and= so on... > > The style means to add S5P_PA_XXX after S3C_PA_XXX with C100 case o= r to > > modify above C100 case like this. >=20 > Use the same conversion as previous one. are you okay? >=20 > #define S5PV210_PA_VIC0 (0xF2000000) > #define S5P_PA_VIC0 S5PV210_PA_VIC0 >=20 > #define S5PV210_PA_VIC1 (0xF2100000) > #define S5P_PA_VIC1 S5PV210_PA_VIC1 >=20 > #define S5PV210_PA_VIC2 (0xF2200000) > #define S5P_PA_VIC2 S5PV210_PA_VIC2 >=20 > #define S5PV210_PA_VIC3 (0xF2300000) > #define S5P_PA_VIC3 S5PV210_PA_VIC3 >=20 > #define S5PV210_PA_SDRAM (0x30000000) > #define S5P_PA_SDRAM S5PV210_PA_SDRAM >=20 No. Did you see above C100? --- C100 #define S3C_PA_ONENAND_BUF S5PC100_PA_ONENAND_BUF #define S3C_SZ_ONENAND_BUF S5PC100_SZ_ONENAND_BUF #define S3C_PA_RTC S5PC100_PA_RTC +#define S5P_PA_FIMC0 S5PC100_PA_FIMC0 +#define S5P_PA_FIMC1 S5PC100_PA_FIMC1 +#define S5P_PA_FIMC2 S5PC100_PA_FIMC2 #define SAMSUNG_PA_ADC S5PC100_PA_TSADC #define SAMSUNG_PA_CFCON S5PC100_PA_CFCON --- V210 #define SAMSUNG_PA_CFCON S5PV210_PA_CFCON #define SAMSUNG_PA_KEYPAD S5PV210_PA_KEYPAD +#define S5P_PA_FIMC0 S5PV210_PA_FIMC0 +#define S5P_PA_FIMC1 S5PV210_PA_FIMC1 +#define S5P_PA_FIMC2 S5PV210_PA_FIMC2 I mean it's just ordering. > > > >> + > >> =A0#endif /* __ASM_ARCH_MAP_H */ > >> diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig > >> index 907ac63..9c79106 100644 > >> --- a/arch/arm/plat-s5p/Kconfig > >> +++ b/arch/arm/plat-s5p/Kconfig > >> @@ -5,6 +5,22 @@ > >> =A0# > >> =A0# Licensed under GPLv2 > >> > >> +config S5P_DEV_FIMC0 > >> + =A0 =A0 bool > >> + =A0 =A0 help > >> + =A0 =A0 =A0 Compile in platform device definitions for FIMC cont= roller 0 > >> + > >> +config S5P_DEV_FIMC1 > >> + =A0 =A0 bool > >> + =A0 =A0 help > >> + =A0 =A0 =A0 Compile in platform device definitions for FIMC cont= roller 1 > >> + > >> +config S5P_DEV_FIMC2 > >> + =A0 =A0 bool > >> + =A0 =A0 help > >> + =A0 =A0 =A0 Compile in platform device definitions for FIMC cont= roller 2 > >> + > >> + > > > > 2 empty lines. > > > >> =A0config PLAT_S5P > >> =A0 =A0 =A0 bool > >> =A0 =A0 =A0 depends on (ARCH_S5P6440 || ARCH_S5P6442 || ARCH_S5PC1= 00 || > >> ARCH_S5PV210 || ARCH_S5PV310) > >> diff --git a/arch/arm/plat-s5p/Makefile b/arch/arm/plat-s5p/Makefi= le > >> index 7e34194..a2d9905 100644 > >> --- a/arch/arm/plat-s5p/Makefile > >> +++ b/arch/arm/plat-s5p/Makefile > >> @@ -19,3 +19,6 @@ obj-y =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 +=3D clock.o > >> =A0obj-y =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0+=3D irq.o > >> =A0obj-$(CONFIG_S5P_EXT_INT) =A0 =A0+=3D irq-eint.o > >> > > > > Please add '# devices' here... > It's not related with this patch. > > > >> +obj-$(CONFIG_S5P_DEV_FIMC0) =A0+=3D dev-fimc0.o > >> +obj-$(CONFIG_S5P_DEV_FIMC1) =A0+=3D dev-fimc1.o > >> +obj-$(CONFIG_S5P_DEV_FIMC2) =A0+=3D dev-fimc2.o > >> diff --git a/arch/arm/plat-s5p/dev-fimc0.c b/arch/arm/plat-s5p/dev-fimc0.c > >> new file mode 100644 > >> index 0000000..8849de4 > >> --- /dev/null > >> +++ b/arch/arm/plat-s5p/dev-fimc0.c > >> @@ -0,0 +1,35 @@ > >> +/* linux/arch/arm/plat-s5p/dev-fimc0.c > >> + * > >> + * Copyright (c) 2010 Samsung Electronics > >> + * > >> + * Base S5P FIMC0 resource and device definitions > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2= as > >> + * published by the Free Software Foundation. > >> + */ > > > > Being 1 empty line is better here. > > > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +static struct resource s5p_fimc_resource[] =3D { > > > > Please change to s5p_fimc0_resource...it'd helpful to merging dev-f= imcX > > files later... > > > >> + =A0 =A0 [0] =3D { > >> + =A0 =A0 =A0 =A0 =A0 =A0 .start =A0=3D S5P_PA_FIMC0, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .end =A0 =A0=3D S5P_PA_FIMC0 + SZ_1M - 1= , > >> + =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0=3D IORESOURCE_MEM, > >> + =A0 =A0 }, > >> + =A0 =A0 [1] =3D { > >> + =A0 =A0 =A0 =A0 =A0 =A0 .start =A0=3D IRQ_FIMC0, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .end =A0 =A0=3D IRQ_FIMC0, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0=3D IORESOURCE_IRQ, > >> + =A0 =A0 }, > >> +}; > >> + > >> +struct platform_device s5p_device_fimc0 =3D { > >> + =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "s5p-fimc", > >> + =A0 =A0 .id =A0 =A0 =A0 =A0 =A0 =A0 =3D 0, > >> + =A0 =A0 .num_resources =A0=3D ARRAY_SIZE(s5p_fimc_resource), > > > > s5p_fimc0_resource... > > > >> + =A0 =A0 .resource =A0 =A0 =A0 =3D s5p_fimc_resource, > > > > s5p_fimc0_resource... > > > >> +}; > >> diff --git a/arch/arm/plat-s5p/dev-fimc1.c b/arch/arm/plat-s5p/dev-fimc1.c > >> new file mode 100644 > >> index 0000000..b1f8970 > >> --- /dev/null > >> +++ b/arch/arm/plat-s5p/dev-fimc1.c > >> @@ -0,0 +1,35 @@ > >> +/* linux/arch/arm/plat-s5p/dev-fimc1.c > >> + * > >> + * Copyright (c) 2010 Samsung Electronics > >> + * > >> + * Base S5P FIMC1 resource and device definitions > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2= as > >> + * published by the Free Software Foundation. > >> + */ > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +static struct resource s5p_fimc_resource[] =3D { > >> + =A0 =A0 [0] =3D { > >> + =A0 =A0 =A0 =A0 =A0 =A0 .start =A0=3D S5P_PA_FIMC1, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .end =A0 =A0=3D S5P_PA_FIMC1 + SZ_1M - 1= , > >> + =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0=3D IORESOURCE_MEM, > >> + =A0 =A0 }, > >> + =A0 =A0 [1] =3D { > >> + =A0 =A0 =A0 =A0 =A0 =A0 .start =A0=3D IRQ_FIMC1, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .end =A0 =A0=3D IRQ_FIMC1, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0=3D IORESOURCE_IRQ, > >> + =A0 =A0 }, > >> +}; > >> + > >> +struct platform_device s5p_device_fimc1 =3D { > >> + =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "s5p-fimc", > >> + =A0 =A0 .id =A0 =A0 =A0 =A0 =A0 =A0 =3D 1, > >> + =A0 =A0 .num_resources =A0=3D ARRAY_SIZE(s5p_fimc_resource), > >> + =A0 =A0 .resource =A0 =A0 =A0 =3D s5p_fimc_resource, > >> +}; > >> diff --git a/arch/arm/plat-s5p/dev-fimc2.c b/arch/arm/plat-s5p/dev-fimc2.c > >> new file mode 100644 > >> index 0000000..20df59d > >> --- /dev/null > >> +++ b/arch/arm/plat-s5p/dev-fimc2.c > >> @@ -0,0 +1,35 @@ > >> +/* linux/arch/arm/plat-s5p/dev-fimc2.c > >> + * > >> + * Copyright (c) 2010 Samsung Electronics > >> + * > >> + * Base S5P FIMC2 resource and device definitions > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2= as > >> + * published by the Free Software Foundation. > >> + */ > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +static struct resource s5p_fimc_resource[] =3D { > >> + =A0 =A0 [0] =3D { > >> + =A0 =A0 =A0 =A0 =A0 =A0 .start =A0=3D S5P_PA_FIMC2, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .end =A0 =A0=3D S5P_PA_FIMC2 + SZ_1M - 1= , > >> + =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0=3D IORESOURCE_MEM, > >> + =A0 =A0 }, > >> + =A0 =A0 [1] =3D { > >> + =A0 =A0 =A0 =A0 =A0 =A0 .start =A0=3D IRQ_FIMC2, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .end =A0 =A0=3D IRQ_FIMC2, > >> + =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0=3D IORESOURCE_IRQ, > >> + =A0 =A0 }, > >> +}; > >> + > >> +struct platform_device s5p_device_fimc2 =3D { > >> + =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "s5p-fimc", > >> + =A0 =A0 .id =A0 =A0 =A0 =A0 =A0 =A0 =3D 2, > >> + =A0 =A0 .num_resources =A0=3D ARRAY_SIZE(s5p_fimc_resource), > >> + =A0 =A0 .resource =A0 =A0 =A0 =3D s5p_fimc_resource, > >> +}; > > > > This is just for your information... > > I'm working on handling plat device in case of various # of each AP= FIMC > > with CONFIG_NR_FIMC... > > So in this case, all of plat data for FIMC will be merged into > > 'plat-s5p/dev-fimc.c' or 'devs.c' later. > > ...but I'm not sure some stuff...anyway... >=20 > If you have these plan, then there's no reason to separate the > dev-fimcX as this patch, Just one file the dev-fimc from now. > Other devices are same rules. >=20 If you want now, just 'dev-fimc.c' is ok...but in that case, need to ad= d '#ifdef CONFIG_S5P_DEV_FIMCX' in there..and 'OR' in Makefile for dev-fi= mc.o > > > >> diff --git a/arch/arm/plat-samsung/include/plat/fimc-core.h > > b/arch/arm/plat- > >> samsung/include/plat/fimc-core.h > >> new file mode 100644 > >> index 0000000..a884ede > >> --- /dev/null > >> +++ b/arch/arm/plat-samsung/include/plat/fimc-core.h > >> @@ -0,0 +1,45 @@ > >> +/* > >> + * arch/arm/plat-samsung/include/plat/fimc-core.h > >> + * > >> + * Copyright 2010 Samsung Electronics Co., Ltd. > >> + * =A0 Sylwester Nawrocki > >> + * > >> + * Samsung camera interface driver core functions > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2= as > >> + * published by the Free Software Foundation. > >> + */ > >> +#ifndef __ASM_PLAT_FIMC_CORE_H > >> +#define __ASM_PLAT_FIMC_CORE_H __FILE__ > >> + > >> +/* > >> + * These functions are only for use with the core support code, s= uch as > >> + * the CPU-specific initialization code. > >> + */ > >> + > >> +#include > >> + > >> +/* Re-define device name to differentiate the subsystem in variou= s SoCs. > > */ > >> +static inline void s3c_fimc_setname(int id, char *name) > >> +{ > >> + =A0 =A0 switch (id) { > >> +#ifdef CONFIG_S5P_DEV_FIMC0 > >> + =A0 =A0 case 0: > >> + =A0 =A0 =A0 =A0 =A0 =A0 s5p_device_fimc0.name =3D name; > >> + =A0 =A0 =A0 =A0 =A0 =A0 break; > >> +#endif > >> +#ifdef CONFIG_S5P_DEV_FIMC1 > >> + =A0 =A0 case 1: > >> + =A0 =A0 =A0 =A0 =A0 =A0 s5p_device_fimc1.name =3D name; > >> + =A0 =A0 =A0 =A0 =A0 =A0 break; > >> +#endif > >> +#ifdef CONFIG_S5P_DEV_FIMC2 > >> + =A0 =A0 case 2: > >> + =A0 =A0 =A0 =A0 =A0 =A0 s5p_device_fimc2.name =3D name; > >> + =A0 =A0 =A0 =A0 =A0 =A0 break; > >> +#endif > >> + =A0 =A0 } > >> +} > >> + > >> +#endif /* __ASM_PLAT_FIMC_CORE_H */ > >> diff --git a/arch/arm/plat-samsung/include/plat/fimc.h b/arch/arm/= plat- > >> samsung/include/plat/fimc.h > >> new file mode 100644 > >> index 0000000..fda2040 > >> --- /dev/null > >> +++ b/arch/arm/plat-samsung/include/plat/fimc.h > >> @@ -0,0 +1,22 @@ > >> +/* linux/arch/arm/plat-samsung/include/plat/fimc.h > >> + * > >> + * Platform header file for S3C/S5P FIMC driver > >> + * > >> + * Copyright (c) 2010 Samsung Electronics > >> + * > >> + * Sylwester Nawrocki, > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2= as > >> + * published by the Free Software Foundation. > >> + */ > >> +#ifndef FIMC_H_ > >> +#define FIMC_H_ > >> + > >> +#include > >> + > >> +extern struct platform_device s5p_device_fimc0; > >> +extern struct platform_device s5p_device_fimc1; > >> +extern struct platform_device s5p_device_fimc2; > > > > Should being in 'plat-samsung/include/plat/devs.h'. > > > >> + > >> +#endif /* FIMC_H_ */ > >> -- > > > > Marek, could you please address as soon as possible? > > Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.