RE: [PATCH] ARM: S5PC100: Cleanup the GPIOlib code

[Kukjin Kim <kgene.kim@samsung.com>]

Kyungmin Park wrote:
> 
> Hi,
> 
Hi,

> There's some comments.
> At least the s5p series use the same .config = &gpio_cfg, so move it
> to common code and then can delete it at each SOC gpiolib.
> 
Hmm..ok..will consider it later.

> Please also check the other team how modified it since there's some
> comments from G  "why do you set each config at for loop. just put it
> at each configuration as is.
> 
Already has been discussed about that with Ben and following is
his comment.
"given that &gpio_cfg is the default, it would have been easier to
make a wrapper for the registration code and have it set any null
config settign to gpio_cfg."
And I agree with Ben's suggestion.

(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.