From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Kyungmin Park' <kmpark@infradead.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org
Subject: RE: [PATCH 06/27] ARM: S5P64X0: 2nd Change to using s3c_gpio_cfgpin_range()
Date: Sat, 02 Oct 2010 20:16:48 +0900 [thread overview]
Message-ID: <014b01cb6223$510dafe0$f3290fa0$%kim@samsung.com> (raw)
In-Reply-To: <AANLkTimBW5udfRN=0=ZHoAwkn+2ewyUX-0B5jLfrsT+i@mail.gmail.com>
Kyungmin Park wrote:
>
> Hi,
>
Hi :-)
> On Fri, Oct 1, 2010 at 9:05 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > This patch changes the code setting ranges of GPIO pins in mach-s5p64x0
using
> > s3c_gpio_cfgpin() to use the recently introduced
s3c_gpio_cfgpin_range().
> > NOTE: This is for missed things from the previous patch.
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > arch/arm/mach-s5p64x0/dev-spi.c | 24 ++++++++++++------------
> > arch/arm/mach-s5p64x0/setup-i2c0.c | 6 ++----
> > arch/arm/mach-s5p64x0/setup-i2c1.c | 6 ++----
> > 3 files changed, 16 insertions(+), 20 deletions(-)
> >
> > diff --git a/arch/arm/mach-s5p64x0/dev-spi.c
b/arch/arm/mach-s5p64x0/dev-spi.c
> > index 5b69ec4..be64fee 100644
> > --- a/arch/arm/mach-s5p64x0/dev-spi.c
> > +++ b/arch/arm/mach-s5p64x0/dev-spi.c
> > @@ -39,20 +39,18 @@ static char *s5p64x0_spi_src_clks[] = {
> > */
> > static int s5p6440_spi_cfg_gpio(struct platform_device *pdev)
> > {
> > + unsigned int base;
> > +
> > switch (pdev->id) {
> > case 0:
> > - s3c_gpio_cfgpin(S5P6440_GPC(0), S3C_GPIO_SFN(2));
> > - s3c_gpio_cfgpin(S5P6440_GPC(1), S3C_GPIO_SFN(2));
> > - s3c_gpio_cfgpin(S5P6440_GPC(2), S3C_GPIO_SFN(2));
> > + base = S5P6440_GPC(0);
> > s3c_gpio_setpull(S5P6440_GPC(0), S3C_GPIO_PULL_UP);
> > s3c_gpio_setpull(S5P6440_GPC(1), S3C_GPIO_PULL_UP);
> > s3c_gpio_setpull(S5P6440_GPC(2), S3C_GPIO_PULL_UP);
>
> Also make a wrapper, s3c_gpio_cfgrange_pullup, then you can also
> remove above codes.
> There's lots of codes use PULL_UP as default pin setup.
>
Thanks for your suggestion.
Ok..will consider it.
(snip)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-10-02 11:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 12:04 [PATCH 00/27] ARM: SAMSUNG: GPIO updates Kukjin Kim
2010-10-01 12:04 ` [PATCH 01/27] ARM: SAMSUNG: Add GPIO configuration for a range of pins Kukjin Kim
2010-10-01 12:04 ` [PATCH 02/27] ARM: S3C64XX: Change dev-audio.c to use S3C_GPIO_SFN() for special functions Kukjin Kim
2010-10-01 12:05 ` [PATCH 03/27] ARM: S3C64XX: Change to using s3c_gpio_cfgpin_range() Kukjin Kim
2010-10-01 12:05 ` [PATCH 04/27] ARM: S5P6442: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 05/27] ARM: S5P64X0: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 06/27] ARM: S5P64X0: 2nd " Kukjin Kim
2010-10-02 1:23 ` Kyungmin Park
2010-10-02 11:16 ` Kukjin Kim [this message]
2010-10-01 12:05 ` [PATCH 07/27] ARM: S5PC100: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 08/27] ARM: S5PV210: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 09/27] ARM: S5PV310: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 10/27] ARM: SAMSUNG: Add s3c_gpio_cfgall_range() function Kukjin Kim
2010-10-01 12:05 ` [PATCH 11/27] ARM: S3C64XX: Change to using s3c_gpio_cfgall_range() Kukjin Kim
2010-10-01 12:05 ` [PATCH 12/27] ARM: S5P6442: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 13/27] ARM: S5P64X0: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 14/27] ARM: S5PC100: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 15/27] ARM: S5PV210: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 16/27] ARM: S5PV310: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 17/27] ARM: S3C64XX: 2nd " Kukjin Kim
2010-10-01 12:05 ` [PATCH 18/27] ARM: S5P64X0: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 19/27] ARM: S5PC100: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 20/27] ARM: S5PV210: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 21/27] ARM: SAMSUNG: Add s3c_gpio_cfgrange_nopull() helper Kukjin Kim
2010-10-01 12:05 ` [PATCH 22/27] ARM: S3C64XX: Change to using s3c_gpio_cfgrange_nopull() Kukjin Kim
2010-10-01 12:05 ` [PATCH 23/27] ARM: S5PC100: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 24/27] ARM: S5PV210: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 25/27] ARM: S3C64XX: 2nd " Kukjin Kim
2010-10-01 12:05 ` [PATCH 26/27] ARM: S5PC100: " Kukjin Kim
2010-10-01 12:05 ` [PATCH 27/27] ARM: S5PV210: " Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='014b01cb6223$510dafe0$f3290fa0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox