From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Tushar Behera' <tushar.behera@linaro.org>,
'Paul Bolle' <pebolle@tiscali.nl>
Cc: 'Tomasz Figa' <tomasz.figa@gmail.com>,
'Tomasz Figa' <t.figa@samsung.com>,
'Sachin Kamat' <sachin.kamat@linaro.org>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, arnd@arndb.de, heiko@sntech.de,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Date: Wed, 14 May 2014 13:08:52 +0900 [thread overview]
Message-ID: <01c101cf6f2a$3970d840$ac5288c0$@samsung.com> (raw)
In-Reply-To: <5372DF9B.4000700@linaro.org>
Tushar Behera wrote:
>
> On 05/13/2014 03:37 PM, Paul Bolle wrote:
> > Kukjin,
> >
> > On Tue, 2014-05-13 at 12:12 +0900, Kukjin Kim wrote:
> >> Tomasz Figa wrote:
> >>> You mean s/sram/sysram/ in compatible strings of Exynos-specific
> >>> reserved areas? If yes, I'm fine, it might be even better. Just
> remember
> >>> to update documentation in patch 2/2 as well.
> >>>
> >> Done. If any problems in my tree, please let me know.
> >
> > It seems this one just hit linux-next (in next-20140513) as "ARM:
> > EXYNOS: Map SYSRAM through generic DT bindings". Its commit now contains
> > this hunk:
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -843,6 +843,7 @@ config ARCH_EXYNOS
> > select HAVE_S3C_RTC if RTC_CLASS
> > select NEED_MACH_MEMORY_H
> > select SPARSE_IRQ
> > + select SYSRAM
> > select USE_OF
> > help
> > Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5)
> >
> > But there's no Kconfig symbol SYSRAM. However, there is a Kconfig symbol
> > SRAM. Did you perhaps do one s/sram/sysram/ too many on the original
> > patch?
> >
>
> Also the compatible string name should be 'mmio-sram' on the DTS files.
>
Paul and Tushar,
Thanks for the pointing out.
Let me fix them, config name and compatible string.
- Kukjin
prev parent reply other threads:[~2014-05-14 4:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 4:16 [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings Sachin Kamat
2014-05-08 4:16 ` [PATCH v3 2/2] Documentation: DT: Exynos: Bind SRAM though DT Sachin Kamat
2014-05-08 16:19 ` Tomasz Figa
2014-05-08 16:18 ` [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings Tomasz Figa
2014-05-09 2:14 ` Kukjin Kim
2014-05-09 4:49 ` Tomasz Figa
2014-05-09 13:46 ` Kukjin Kim
2014-05-13 3:12 ` Kukjin Kim
2014-05-13 10:07 ` Paul Bolle
2014-05-14 3:14 ` Tushar Behera
2014-05-14 4:08 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c101cf6f2a$3970d840$ac5288c0$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox