From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Maurus Cuelenaere' <mcuelenaere@gmail.com>,
linux-samsung-soc@vger.kernel.org
Cc: ben-linux@fluff.org, 'Abhilash Kesavan' <a.kesavan@samsung.com>
Subject: RE: [PATCH] ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used
Date: Sat, 02 Apr 2011 11:23:39 +0900 [thread overview]
Message-ID: <023601cbf0dd$00e7c8e0$02b75aa0$%kim@samsung.com> (raw)
In-Reply-To: <4cabb531.cf7d0e0a.19d7.08b2@mx.google.com>
Maurus Cuelenaere wrote:
>
> s3c_pm_show_resume_irqs() is used by some s3c_pm_arch_show_resume_irqs()
> implementations, which get included through mach/pm-core.h. Add
> __maybe_unused
> to silence warnings when it isn't used (e.g. on S3C64XX platforms).
>
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
> arch/arm/plat-samsung/pm.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c
> index 27cfca5..ad6dd63 100644
> --- a/arch/arm/plat-samsung/pm.c
> +++ b/arch/arm/plat-samsung/pm.c
> @@ -214,8 +214,9 @@ void s3c_pm_do_restore_core(struct sleep_save *ptr,
int
> count)
> *
> * print any IRQs asserted at resume time (ie, we woke from)
> */
> -static void s3c_pm_show_resume_irqs(int start, unsigned long which,
> - unsigned long mask)
> +static void __maybe_unused s3c_pm_show_resume_irqs(int start,
> + unsigned long which,
> + unsigned long mask)
> {
> int i;
>
> --
Missed for a long time :(
Abhilash, thanks for your reminder.
Ok, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2011-04-02 2:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 23:30 [PATCH] ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used Maurus Cuelenaere
2011-04-02 2:23 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='023601cbf0dd$00e7c8e0$02b75aa0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=a.kesavan@samsung.com \
--cc=ben-linux@fluff.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mcuelenaere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox