From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Chanwoo Choi' <cw00.choi@samsung.com>
Cc: "'Rafael J. Wysocki'" <rjw@sisk.pl>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'MyungJoo Ham' <myungjoo.ham@samsung.com>,
'Sylwester Nawrocki' <snjw23@gmail.com>,
linux-pm@lists.linux-foundation.org,
'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>,
'linux-kernel' <linux-kernel@vger.kernel.org>
Subject: RE: [PATCHv3] ARM: EXYNOS4: Support for generic I/O power domains on EXYNOS4210
Date: Sat, 16 Jul 2011 12:19:19 +0900 [thread overview]
Message-ID: <035201cc4367$2b165c80$81431580$%kim@samsung.com> (raw)
In-Reply-To: <4E16A171.7040509@samsung.com>
Chanwoo Choi wrote:
>
> Kukjin Kim wrote:
(snip)
> >> @@ -183,6 +183,7 @@ config MACH_NURI
> >> select EXYNOS4_SETUP_SDHCI
> >> select EXYNOS4_SETUP_USB_PHY
> >> select SAMSUNG_DEV_PWM
> >> + select PM_GENERIC_DOMAINS if PM
> >
> > Do you _really_ think this should be under MACH_NURI?
> >
> This patch apply the generic power-domain to NURI board.
I mean, the PM_GENERIC_DOMAINS feature depends on CPU not board even though this is for only NURI board.
(snip)
> >> diff --git a/arch/arm/mach-exynos4/include/mach/pm-exynos4210.h
> >> b/arch/arm/mach-exynos4/include/mach/pm-exynos4210.h
> >> new file mode 100644
> >> index 0000000..ab09034
> >> --- /dev/null
> >> +++ b/arch/arm/mach-exynos4/include/mach/pm-exynos4210.h
> >> @@ -0,0 +1,53 @@
> >> +/* linux/arch/arm/mach-exynos4/include/mach/pm-exynos4.h
> >
> > According to your file name, should be linux/arch/arm/mach-
> exynos4/include/mach/pm-exynos4210.h ?
>
I said just typo...
+/* linux/arch/arm/mach-exynos4/include/mach/pm-exynos4210.h
> This patch support only power-domain of EXYNOS4210, so I named "pm-
> exynos4210.h"
> If EXYNOS4 series board will be released, I will modify include file name
> from "pm-exynos4210.h" to "pm-exynos4.h" to support all EXYNOS4 series.
No need it, it's different.
(snip)
> > Would be better if you could add some common function for pd_power_up and
> _down...
>
> What do you mean about common function?
>
I thought, pd_power_up and _down can be implemented in one function.
(snip)
> > I wonder why we need to add this for handling power domain not update current
> pd.
>
See arch/arm/mach-exynos4/dev-pd.c
I mean, we _really_ need to keep duplication files for handling power domain?...
(snip)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-07-16 3:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 1:24 [PATCHv3] ARM: EXYNOS4: Support for generic I/O power domains on EXYNOS4210 Chanwoo Choi
2011-07-08 5:28 ` Kukjin Kim
2011-07-08 6:19 ` Chanwoo Choi
2011-07-16 3:19 ` Kukjin Kim [this message]
2011-07-16 3:58 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='035201cc4367$2b165c80$81431580$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@sisk.pl \
--cc=snjw23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox