RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

[Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]

Felipe Balbi wrote:
> Hi,
> 
Hi Felipe,

[...]

> > Right, DWC has version number, but that being the kind of USB controller
> > (USB 2.0 and USB 3.0)
> >
> > DWC2: USB High Speed controller (as also indicated in the patch from
> > Paul: [RFC PATCH 0/6] DWC2 DesignWare HS OTG driver)
> > DWC3: USB Super Speed controller
> >
> > Is it fine if we use something like shown below, as suggested by you
earlier ?
> >
> > -     { .compatible = "samsung,exynos-dwc3" },
> > +     { .compatible = "samsung,synopsis-dwc3" }
> 
> You're both missing a point here. The synopsys IP driver is called
> dwc3.ko and that's compatible with synopsys,dwc3. Your glue layer driver
> (dwc3-exynos.ko) is compatible with your platform, so
> samsung,exynos-dwc3 sounds correct to me.
> 
Hmm...yeah, you're right and agreed.

However, we need to use more clear name there like "samsung,exynos-dwusb3"
in compatible, because you know there are lots of other IPs in Synopsis
Design Ware brand. So we have to include usb in compatible for that.

> The glue layer is just to "abstract" away the integration details of the
> IP core into a specific platform.
> 
Right.

Thanks.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html