From: Kukjin Kim <kgene@kernel.org>
To: 'Jungseok Lee' <jays.lee@samsung.com>,
'Sachin Kamat' <sachin.kamat@linaro.org>
Cc: 'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH V2] ARM: EXYNOS: implement pm_power_off for EXYNOS5440
Date: Mon, 30 Sep 2013 16:25:15 +0900 [thread overview]
Message-ID: <069501cebdae$357285a0$a05790e0$@org> (raw)
In-Reply-To: <003401cebd9c$d29c75a0$77d560e0$%lee@samsung.com>
Jungseok Lee wrote:
>
> On Monday, September 30, 2013 12:04 PM, Sachin Kamat wrote:
> > On 30 September 2013 07:02, Jungseok Lee <jays.lee@samsung.com> wrote:
> >
> > > + /* turn off all power domains */
> > > + addr = of_iomap(np, 0) + 0x14;
> > > + __raw_writel(0x1, addr);
> >
> > Actually my comment was more about mentioning what these above values
> > especially 0x14 represented? Either using a macro (preferred way) or
> > atleast a comment.
>
> How about changing a variable name "addr" to "power_down_reg"?
>
> 0x14 is only available for exynos5440, not exynos5. Currently, there are
> no
> macros for specific SoCs in exynos5, such as exynos5250 or exynos5420.
> That is
> why I hesitate to add a macro for 0x14.
>
I think current patch looks good to me, and in this case I don't have any
idea why we should macro for just one time usage.
Applied, thanks.
Kukjin
next prev parent reply other threads:[~2013-09-30 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 1:32 [PATCH V2] ARM: EXYNOS: implement pm_power_off for EXYNOS5440 Jungseok Lee
2013-09-30 3:03 ` Sachin Kamat
2013-09-30 5:20 ` Jungseok Lee
2013-09-30 7:25 ` Kukjin Kim [this message]
2013-09-30 8:26 ` Sachin Kamat
2013-09-30 8:41 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='069501cebdae$357285a0$a05790e0$@org' \
--to=kgene@kernel.org \
--cc=jays.lee@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox