RE: [PATCH v7] ARM: dts: Prepare node labels for exynos5250

[Kukjin Kim <kgene.kim@samsung.com>]

Andreas Färber wrote:
> 
> Allows them to be extended by reference.
> 
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v6 -> v7:
>  * Dropped uart* labels (Tomasz Figa)
> 
>  v6: Split off from Snow/SMDK cleanups (Doug Anderson)
> 
>  arch/arm/boot/dts/exynos5250.dtsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 492e1eff37bd..42eafd19cfb2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -218,7 +218,7 @@
>  		clock-names = "fimg2d";
>  	};
> 
> -	codec@11000000 {
> +	mfc: codec@11000000 {
>  		compatible = "samsung,mfc-v6";
>  		reg = <0x11000000 0x10000>;
>  		interrupts = <0 96 0>;
> @@ -227,7 +227,7 @@
>  		clock-names = "mfc";
>  	};
> 
> -	rtc@101E0000 {
> +	rtc: rtc@101E0000 {
>  		clocks = <&clock CLK_RTC>;
>  		clock-names = "rtc";
>  		status = "disabled";
> @@ -261,7 +261,7 @@
>  		clock-names = "uart", "clk_uart_baud0";
>  	};
> 
> -	sata@122F0000 {
> +	sata: sata@122F0000 {
>  		compatible = "snps,dwc-ahci";
>  		samsung,sata-freq = <66>;
>  		reg = <0x122F0000 0x1ff>;
> @@ -573,7 +573,7 @@
>  		#phy-cells = <1>;
>  	};
> 
> -	usb@12110000 {
> +	ehci: usb@12110000 {

I'm not sure which one is recommended between above and "ehci: ehci@12110000 {"

>  		compatible = "samsung,exynos4210-ehci";
>  		reg = <0x12110000 0x100>;
>  		interrupts = <0 71 0>;
> @@ -588,7 +588,7 @@
>  		};
>  	};
> 
> -	usb@12120000 {
> +	ohci: usb@12120000 {

Same as above...

>  		compatible = "samsung,exynos4210-ohci";
>  		reg = <0x12120000 0x100>;
>  		interrupts = <0 71 0>;
> @@ -725,7 +725,7 @@
>  		clock-names = "gscl";
>  	};
> 
> -	hdmi {
> +	hdmi: hdmi {

Should be

+	hdmi: hdmi@14530000 { ?

>  		compatible = "samsung,exynos4212-hdmi";
>  		reg = <0x14530000 0x70000>;
>  		interrupts = <0 95 0>;
> @@ -751,14 +751,14 @@
>  		#phy-cells = <0>;
>  	};
> 
> -	dp-controller@145B0000 {
> +	dp: dp-controller@145B0000 {
>  		clocks = <&clock CLK_DP>;
>  		clock-names = "dp";
>  		phys = <&dp_phy>;
>  		phy-names = "dp";
>  	};
> 
> -	fimd@14400000 {
> +	fimd: fimd@14400000 {
>  		clocks = <&clock CLK_SCLK_FIMD1>, <&clock CLK_FIMD1>;
>  		clock-names = "sclk_fimd", "fimd";
>  	};
> --
> 2.0.4