From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sachin Kamat' <sachin.kamat@linaro.org>,
linux-samsung-soc@vger.kernel.org
Cc: patches@linaro.org
Subject: RE: [PATCH 1/1] ARM: S3C24XX: Fix warnings in irq-s3c2416.c
Date: Wed, 16 Jan 2013 16:06:07 -0800 [thread overview]
Message-ID: <0c0101cdf446$738f9490$5aaebdb0$@samsung.com> (raw)
In-Reply-To: <1357816660-18224-1-git-send-email-sachin.kamat@linaro.org>
Sachin Kamat wrote:
>
> Fixes the following warnings:
> arch/arm/mach-s3c24xx/irq-s3c2416.c:226:17: warning:
> symbol 's3c2416_irq_second' was not declared. Should it be static?
> arch/arm/mach-s3c24xx/irq-s3c2416.c:332:5: warning:
> symbol 's3c2416_irq_suspend' was not declared. Should it be static?
> arch/arm/mach-s3c24xx/irq-s3c2416.c:339:6: warning:
> symbol 's3c2416_irq_resume' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/mach-s3c24xx/irq-s3c2416.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/irq-s3c2416.c b/arch/arm/mach-
> s3c24xx/irq-s3c2416.c
> index ff141b0..f282670 100644
> --- a/arch/arm/mach-s3c24xx/irq-s3c2416.c
> +++ b/arch/arm/mach-s3c24xx/irq-s3c2416.c
> @@ -223,7 +223,7 @@ static void s3c2416_irq_unmask_second(struct
> irq_data *data)
> __raw_writel(mask, S3C2416_INTMSK2);
> }
>
> -struct irq_chip s3c2416_irq_second = {
> +static struct irq_chip s3c2416_irq_second = {
> .irq_ack = s3c2416_irq_ack_second,
> .irq_mask = s3c2416_irq_mask_second,
> .irq_unmask = s3c2416_irq_unmask_second,
> @@ -329,14 +329,14 @@ static struct sleep_save irq_save[] = {
> SAVE_ITEM(S3C2416_INTMSK2),
> };
>
> -int s3c2416_irq_suspend(void)
> +static int s3c2416_irq_suspend(void)
> {
> s3c_pm_do_save(irq_save, ARRAY_SIZE(irq_save));
>
> return 0;
> }
>
> -void s3c2416_irq_resume(void)
> +static void s3c2416_irq_resume(void)
> {
> s3c_pm_do_restore(irq_save, ARRAY_SIZE(irq_save));
> }
> --
> 1.7.4.1
Applied, thanks.
- Kukjin
prev parent reply other threads:[~2013-01-17 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 11:17 [PATCH 1/1] ARM: S3C24XX: Fix warnings in irq-s3c2416.c Sachin Kamat
2013-01-17 0:06 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0c0101cdf446$738f9490$5aaebdb0$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox