From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sachin Kamat' <sachin.kamat@linaro.org>,
'Kukjin Kim' <kgene@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, patches@linaro.org
Subject: RE: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file
Date: Wed, 24 Jul 2013 16:31:05 +0900 [thread overview]
Message-ID: <0e7c01ce883f$c1edafe0$45c90fa0$%kim@samsung.com> (raw)
In-Reply-To: <CAK9yfHzMyfprmtGkDxwbQcYUXueCTPYVZDU_uM=oMudAiaoC_w@mail.gmail.com>
Sachin Kamat wrote:
>
> On 24 July 2013 08:43, Kukjin Kim <kgene@kernel.org> wrote:
> > Kukjin Kim wrote:
> >>
> >> Sachin Kamat wrote:
> >> >
> >> > Remove unused declarations that got left behind subsequent to
> >> > making Exynos a DT-only platform.
> >> >
> >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> > ---
> >> > arch/arm/mach-exynos/common.h | 41
> > -----------------------------------
> >> --
> >> > ----
> >> > 1 file changed, 41 deletions(-)
> >> >
> >
> > [...]
> >
> >> > -
> >> > -struct device_node;
> >> > -
> >> > extern struct smp_operations exynos_smp_ops;
> >> >
> >> > extern void exynos_cpu_die(unsigned int cpu);
> >> > --
> >> > 1.7.9.5
> >>
> >> Looks good to me, applied into -cleanup.
> >>
> > Just note, needed following additionally.
> >
> > -struct device_node;
> > -void combiner_init(void __iomem *combiner_base, struct device_node *np,
> > - unsigned int max_nr, int irq_base);
> > -
>
> There is already a patch to clean that up [1] submitted earlier as
> part of combiner cleanup series.
> Please apply that first or squash it into this one.
>
> [1] https://lkml.org/lkml/2013/6/26/296
>
Already did when I applied.
Thanks, Kukjin
next prev parent reply other threads:[~2013-07-24 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 8:57 [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file Sachin Kamat
2013-07-22 16:30 ` Tomasz Figa
2013-07-24 2:31 ` Kukjin Kim
2013-07-24 3:13 ` Kukjin Kim
2013-07-24 3:37 ` Sachin Kamat
2013-07-24 7:31 ` Kukjin Kim [this message]
2013-07-24 9:00 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0e7c01ce883f$c1edafe0$45c90fa0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox