From: Tomasz Figa <t.figa@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Tomasz Figa <t.figa@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: [PATCH 4/8] clk: max77686: Make max77686_clk_register() return struct clk *
Date: Thu, 17 Oct 2013 18:30:38 +0200 [thread overview]
Message-ID: <1382027442-1992-5-git-send-email-t.figa@samsung.com> (raw)
In-Reply-To: <1382027442-1992-1-git-send-email-t.figa@samsung.com>
As a preparation for further patches, this patch modifies the clock
registration helper function to return a pointer to the newly registered
clock. No functional change is done to the driver.
Signed-off-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/clk/clk-max77686.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
index 5d78460..2e6ba0e 100644
--- a/drivers/clk/clk-max77686.c
+++ b/drivers/clk/clk-max77686.c
@@ -112,27 +112,26 @@ static struct clk_init_data max77686_clks_init[MAX77686_CLKS_NUM] = {
},
};
-static int max77686_clk_register(struct device *dev,
+static struct clk *max77686_clk_register(struct device *dev,
struct max77686_clk *max77686)
{
struct clk *clk;
struct clk_hw *hw = &max77686->hw;
clk = clk_register(dev, hw);
-
if (IS_ERR(clk))
- return -ENOMEM;
+ return clk;
max77686->lookup = kzalloc(sizeof(struct clk_lookup), GFP_KERNEL);
if (!max77686->lookup)
- return -ENOMEM;
+ return ERR_PTR(-ENOMEM);
max77686->lookup->con_id = hw->init->name;
max77686->lookup->clk = clk;
clkdev_add(max77686->lookup);
- return 0;
+ return clk;
}
static int max77686_clk_probe(struct platform_device *pdev)
@@ -154,12 +153,16 @@ static int max77686_clk_probe(struct platform_device *pdev)
}
for (i = 0; i < MAX77686_CLKS_NUM; i++) {
+ struct clk *clk;
+
max77686_clks[i]->iodev = iodev;
max77686_clks[i]->mask = 1 << i;
max77686_clks[i]->hw.init = &max77686_clks_init[i];
- ret = max77686_clk_register(&pdev->dev, max77686_clks[i]);
- if (ret) {
+ clk = max77686_clk_register(&pdev->dev, max77686_clks[i]);
+ if (IS_ERR(clk)) {
+ ret = PTR_ERR(clk);
+
switch (i) {
case MAX77686_CLK_AP:
dev_err(&pdev->dev, "Fail to register CLK_AP\n");
--
1.8.3.2
next prev parent reply other threads:[~2013-10-17 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 16:30 [PATCH 0/8] clk: max77686: Clock provider implementation fixes Tomasz Figa
[not found] ` <1382027442-1992-1-git-send-email-t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-10-17 16:30 ` [PATCH 1/8] clk: max77686: Correct callback used for checking clock status Tomasz Figa
2013-10-17 16:30 ` [PATCH 2/8] clk: max77686: Provide .recalc_rate() operation Tomasz Figa
2013-10-17 16:30 ` [PATCH 3/8] clk: max77686: Refactor successful exit of probe function Tomasz Figa
2013-10-21 9:41 ` Sachin Kamat
2013-10-17 16:30 ` Tomasz Figa [this message]
2013-10-17 16:30 ` [PATCH 5/8] clk: max77686: Fix clean-up in error and remove paths Tomasz Figa
2013-10-17 16:30 ` [PATCH 6/8] clk: max77686: Refactor driver data handling Tomasz Figa
2013-10-17 16:30 ` [PATCH 7/8] clk: max77686: Register OF clock provider Tomasz Figa
2013-10-17 16:30 ` [PATCH 8/8] ARM: dts: Add clock provider specific properties to max77686 node Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382027442-1992-5-git-send-email-t.figa@samsung.com \
--to=t.figa@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox