From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators Date: Mon, 17 Feb 2014 09:07:34 +0100 Message-ID: <1392624454.3755.12.camel@AMDC1943> References: <1392282847-25444-1-git-send-email-k.kozlowski@samsung.com> <1392282847-25444-12-git-send-email-k.kozlowski@samsung.com> <1392383156.12506.20.camel@AMDC1943> <20140214210502.GX4451@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:42902 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbaBQIHj (ORCPT ); Mon, 17 Feb 2014 03:07:39 -0500 In-reply-to: <20140214210502.GX4451@sirena.org.uk> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Mark Brown Cc: Yadwinder Singh Brar , Sangbeom Kim , Samuel Ortiz , Lee Jones , linux-kernel , linux-samsung-soc , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Chanwoo Choi , Liam Girdwood , Tomasz Figa On Fri, 2014-02-14 at 21:05 +0000, Mark Brown wrote: > On Fri, Feb 14, 2014 at 02:05:56PM +0100, Krzysztof Kozlowski wrote: > > On Thu, 2014-02-13 at 17:46 +0530, Yadwinder Singh Brar wrote: > > > - low-power mode; > > - low-power mode controlled by PWREN; > > Although not all are present for each regulator. > > What exactly is low power mode and how does it interact with the enable? > The name suggests it's a more efficient mode for use with low current > drain, is that right? Yes, it is (i.e. ground current on battery load typically reduced from 8mA to 1.5mA). In this mode for Buck5 and LDO-s the regulator is enabled but output current is limited to 5 mA. > > > A generic solution for operating mode of regulators (not only s2mps11 > > and s5m8767) could cover all of these above or just a subset, for > > example regulator bindings could look like: > > - regulator-mode-suspend; /* PWR controls: on/off or low-power mode */ > > - regulator-mode-low-power; /* Low power mode */ > > Those properties have awfully generic names and part of what I was > wondering above is if the low power mode maps onto the idle or standby > modes that the API defines? We don't cover those in the bindings yet > since they are unfortunately fuzzy but perhaps we need to do so. The low power maps to REGULATOR_MODE_IDLE or REGULATOR_MODE_STANDBY (depending on the understanding of "more efficient" and "most efficient" for light loads). However the suspend mode of S5M8767/S2MPS14 is more like automatic regulator disable by SoC. Best regards, Krzysztof