Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Lee Jones <lee.jones@linaro.org>,
	Stephen Warren <swarren@nvidia.com>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: abrestic@chromium.org, dgreid@chromium.org,
	Olof Johansson <olof@lixom.net>, Simon Glass <sjg@chromium.org>,
	linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
	David Hendricks <dhendrix@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly
Date: Thu, 17 Apr 2014 10:59:24 -0700	[thread overview]
Message-ID: <1397757570-19750-2-git-send-email-dianders@chromium.org> (raw)
In-Reply-To: <1397757570-19750-1-git-send-email-dianders@chromium.org>

From: David Hendricks <dhendrix@chromium.org>

To avoid spamming the EC we calculate the time between the previous
transfer and the current transfer and force a delay if the time delta
is too small.

However, a small miscalculation causes the delay period to be
far too short. Most noticably this impacts commands with a long
turnaround time such as EC firmware reads and writes.

Signed-off-by: David Hendricks <dhendrix@chromium.org>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 drivers/mfd/cros_ec_spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index 84af8d7..c185eb6 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -219,7 +219,7 @@ static int cros_ec_command_spi_xfer(struct cros_ec_device *ec_dev,
 		ktime_get_ts(&ts);
 		delay = timespec_to_ns(&ts) - ec_spi->last_transfer_ns;
 		if (delay < EC_SPI_RECOVERY_TIME_NS)
-			ndelay(delay);
+			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
 	}
 
 	/* Transmit phase - send our message */
-- 
1.9.1.423.g4596e3a

  reply	other threads:[~2014-04-17 18:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17 17:59 [PATCH 0/7] Add cros_ec changes for newer boards Doug Anderson
2014-04-17 17:59 ` Doug Anderson [this message]
     [not found]   ` <1397757570-19750-2-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-18 17:27     ` [PATCH 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly Simon Glass
2014-04-17 17:59 ` [PATCH 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi Doug Anderson
     [not found]   ` <1397757570-19750-3-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-18 17:28     ` Simon Glass
     [not found]       ` <CAPnjgZ034FrVVphJCmX5jZE8LeWOEBjsH7M=2C_meM0fMss1NA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-18 21:15         ` Doug Anderson
2014-04-18 21:43           ` Simon Glass
     [not found] ` <1397757570-19750-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-17 17:59   ` [PATCH 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable Doug Anderson
2014-04-18 17:26     ` Simon Glass
2014-04-17 17:59   ` [PATCH 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources Doug Anderson
2014-04-18 17:29     ` Simon Glass
2014-04-17 17:59 ` [PATCH 4/7] mfd: cros_ec: spi: Increase cros_ec_spi deadline from 5ms to 100ms Doug Anderson
2014-04-18 17:30   ` Simon Glass
2014-04-17 17:59 ` [PATCH 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2 Doug Anderson
2014-04-21 18:18   ` Stephen Warren
     [not found]     ` <535560E9.5040108-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-04-21 19:35       ` Doug Anderson
2014-04-21 20:03         ` Stephen Warren
     [not found]   ` <1397757570-19750-8-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-05-15 18:42     ` Stephen Warren
     [not found]       ` <53750A9A.8000808-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-15 18:55         ` Doug Anderson
2014-05-15 20:12           ` Olof Johansson
2014-05-19  9:18             ` Lee Jones
2014-04-17 18:23 ` [PATCH 0/7] Add cros_ec changes for newer boards Andrew Bresticker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397757570-19750-2-git-send-email-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=abrestic@chromium.org \
    --cc=dgreid@chromium.org \
    --cc=dhendrix@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sameo@linux.intel.com \
    --cc=sjg@chromium.org \
    --cc=swarren@nvidia.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox