Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Kukjin Kim <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Tomasz Figa <tomasz.figa@gmail.com>,
	arm@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Ben Dooks <ben-linux@fluff.org>
Subject: [PATCH 1/9] ARM: s3c64xx: add I2C dependencies where needed
Date: Thu, 12 Feb 2015 20:35:38 +0100	[thread overview]
Message-ID: <1423769746-582629-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1423769746-582629-1-git-send-email-arnd@arndb.de>

The SMDK6410_WM1190_EV1 and SMDK6410_WM1192_EV1 add-on
cards select MFD_WM*_I2C, but they ignore the fact that I2C
may be compiled as a loadable module.

This patch adds a dependency on I2C, which means we avoid
the build errors, but can end up in a case where the options
are hidden from the user when I2C is turned off.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>
---
 arch/arm/mach-s3c64xx/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 26ca2427e53d..eff95e950d81 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -189,6 +189,7 @@ endchoice
 config SMDK6410_WM1190_EV1
 	bool "Support Wolfson Microelectronics 1190-EV1 PMIC card"
 	depends on MACH_SMDK6410
+	depends on I2C=y
 	select MFD_WM8350_I2C
 	select REGULATOR
 	select REGULATOR_WM8350
@@ -203,6 +204,7 @@ config SMDK6410_WM1190_EV1
 config SMDK6410_WM1192_EV1
 	bool "Support Wolfson Microelectronics 1192-EV1 PMIC card"
 	depends on MACH_SMDK6410
+	depends on I2C=y
 	select MFD_WM831X
 	select MFD_WM831X_I2C
 	select REGULATOR
@@ -269,8 +271,8 @@ config MACH_SMARTQ7
 
 config MACH_WLF_CRAGG_6410
 	bool "Wolfson Cragganmore 6410"
+	depends on I2C=y
 	select CPU_S3C6410
-	select I2C
 	select LEDS_GPIO_REGISTER
 	select S3C64XX_DEV_SPI0
 	select S3C64XX_SETUP_FB_24BPP
-- 
2.1.0.rc2

  reply	other threads:[~2015-02-12 19:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 19:35 [PATCH 0/9] ARM: samsung: randconfig build fixes Arnd Bergmann
2015-02-12 19:35 ` Arnd Bergmann [this message]
2015-02-12 19:35 ` [PATCH 2/9] ARM: s3c64xx: fix building without CONFIG_PM_SLEEP Arnd Bergmann
2015-02-12 19:35 ` [PATCH 3/9] ARM: s3c64xx: fix __initdata section mismatch Arnd Bergmann
2015-02-12 19:35 ` [PATCH 4/9] ARM: s3c24xx: use SAMSUNG_WAKEMASK for s3c2416 Arnd Bergmann
2015-02-12 19:35 ` [PATCH 5/9] ARM: s3c24xx: fix building without PM_SLEEP Arnd Bergmann
2015-02-12 19:35 ` [PATCH 6/9] ARM: s3c24xx: fix header file inclusions Arnd Bergmann
2015-02-12 19:35 ` [PATCH 7/9] ARM: s3c24xx: avoid a Kconfig warning Arnd Bergmann
2015-02-18  0:21 ` [PATCH 0/9] ARM: samsung: randconfig build fixes Kukjin Kim
2015-03-02 19:50   ` Kukjin Kim
2015-03-02 21:28     ` Arnd Bergmann
2015-03-02 21:28 ` [PATCH 8/9] ARM: EXYNOS: suspend requires regulator access Arnd Bergmann
2015-03-03  7:29   ` Javier Martinez Canillas
2015-03-04 19:44   ` Krzysztof Kozłowski
2015-03-04 21:14     ` Arnd Bergmann
2015-03-02 21:29 ` [PATCH 9/9] ARM: EXYNOS: make exynos 4210 cpuidle build without SMP Arnd Bergmann
2015-03-03 12:35   ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423769746-582629-2-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox