From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: EXYNOS: Handle of_find_device_by_node and kstrdup failures Date: Tue, 24 Feb 2015 16:42:42 +0100 Message-ID: <1424792562.6775.3.camel@AMDC1943> References: <1422984529-17729-1-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:56856 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbbBXPmr (ORCPT ); Tue, 24 Feb 2015 10:42:47 -0500 In-reply-to: <1422984529-17729-1-git-send-email-k.kozlowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Bartlomiej Zolnierkiewicz , Marek Szyprowski On wto, 2015-02-03 at 18:28 +0100, Krzysztof Kozlowski wrote: > Prevent possible NULL pointer dereference of pointer returned by > of_find_device_by_node(). Handle this by skipping such power domain. > > Additionally fail the init on kstrdup() failure. Such case is actually > not fatal because the name for power domain allocated by kstrdup() is > used only in printk. Still as a precaution handle this as an error > condition. > > Signed-off-by: Krzysztof Kozlowski Hi Kukjin, What is the status of this patch and the "ARM: EXYNOS: Handle of of_iomap() failure". The latter should be in your tree but I cannot find it. Best regards, Krzysztof > --- > arch/arm/mach-exynos/pm_domains.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c > index fd7640a6b503..4c6c29ba58ef 100644 > --- a/arch/arm/mach-exynos/pm_domains.c > +++ b/arch/arm/mach-exynos/pm_domains.c > @@ -116,6 +116,12 @@ static __init int exynos4_pm_init_power_domain(void) > struct device *dev; > > pdev = of_find_device_by_node(np); > + if (!pdev) { > + pr_err("%s: failed to find device for node %s\n", > + __func__, np->name); > + of_node_put(np); > + continue; > + } > dev = &pdev->dev; > > pd = kzalloc(sizeof(*pd), GFP_KERNEL); > @@ -126,6 +132,12 @@ static __init int exynos4_pm_init_power_domain(void) > } > > pd->pd.name = kstrdup(np->name, GFP_KERNEL); > + if (!pd->pd.name) { > + kfree(pd); > + of_node_put(np); > + return -ENOMEM; > + } > + > pd->name = pd->pd.name; > pd->base = of_iomap(np, 0); > if (!pd->base) {