From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Kukjin Kim <kgene@kernel.org>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH 1/4] ARM: dts: Include exynos5250-pinctrl after the nodes were defined
Date: Tue, 7 Jul 2015 22:36:27 -0700 [thread overview]
Message-ID: <1436333790-18219-2-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1436333790-18219-1-git-send-email-javier@osg.samsung.com>
The dtc compiler combines all the defined nodes that have the same path
so a device node definition can be in one file and later be extended in
another one.
That's the case of the Exynos5250 pinctrl device nodes that are defined
in the exynos5250.dtsi file and extended in exynos5250-pinctrl.dtsi.
But since the exynos5250.dtsi file includes the exynos5250-pinctrl.dtsi
before the pinctrl device nodes are actually defined, the definition of
the pinctrl device nodes happens in exynos5250-pinctrl.dtsi and are
extended in exynos5250.dtsi.
That is the opposite of the original intention so even when there is no
difference in practice, the exynos5250-pinctrl.dtsi include should be
moved at the end of the exynos5250.dtsi file after the pinctrl device
nodes have been already defined.
This will also allow to later change the exynos5250-pinctrl.dtsi file
to use labels instead of full paths to extend the pinctrl nodes. Since
keeping the include at the top, would cause a dtc build error due the
pinctrl labels not being defined yet.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index bf9bee67c416..4a1f88300a28 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -19,7 +19,6 @@
#include <dt-bindings/clock/exynos5250.h>
#include "exynos5.dtsi"
-#include "exynos5250-pinctrl.dtsi"
#include "exynos4-cpu-thermal.dtsi"
#include <dt-bindings/clock/exynos-audss-clk.h>
@@ -1062,3 +1061,5 @@
clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>;
clock-names = "uart", "clk_uart_baud0";
};
+
+#include "exynos5250-pinctrl.dtsi"
--
2.4.3
next prev parent reply other threads:[~2015-07-08 5:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 5:36 [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes Javier Martinez Canillas
2015-07-08 5:36 ` Javier Martinez Canillas [this message]
2015-07-08 8:24 ` [PATCH 1/4] ARM: dts: Include exynos5250-pinctrl after the nodes were defined Krzysztof Kozlowski
2015-07-08 5:36 ` [PATCH 2/4] ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths Javier Martinez Canillas
2015-07-08 8:29 ` Krzysztof Kozlowski
[not found] ` <559CDF66.6080609-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-07-08 14:05 ` Javier Martinez Canillas
2015-07-08 23:53 ` Krzysztof Kozlowski
2015-07-08 5:36 ` [PATCH 3/4] ARM: dts: Include exynos5420-pinctrl after the nodes were defined Javier Martinez Canillas
2015-07-08 8:25 ` Krzysztof Kozlowski
2015-07-08 8:27 ` [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes Krzysztof Kozlowski
[not found] ` <559CDEDA.50608-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-07-08 14:15 ` Javier Martinez Canillas
2015-07-08 23:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436333790-18219-2-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox