From: Alban Browaeys <alban.browaeys@gmail.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
gabriel@unseen.is, linux-samsung-soc@vger.kernel.org,
dmaengine@vger.kernel.org, sylvester.nawrocki@gmail.com,
Robert Baldyga <r.baldyga@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] [RFC PATCH] dmaengine: pl330: residual - do not reset on last descriptor.
Date: Wed, 08 Jul 2015 12:54:44 +0200 [thread overview]
Message-ID: <1436352884.1160.6.camel@gmail.com> (raw)
In-Reply-To: <1436271235.26922.6.camel@gmail.com>
Le mardi 07 juillet 2015 à 14:13 +0200, Alban Browaeys a écrit :
> Le mardi 07 juillet 2015 à 20:53 +0900, Krzysztof Kozlowski a écrit
> > >
> > I am not quite sure what bug you are trying to fix here. It isn't
> > described in commit message. Also I don't get why the residue=0 is
> > being removed. This will break the residue calculation...
> >
> > Some time ago I posted a patch fixing sound issues on Odroid XU3.
> > Today Vinod applied it:
> > https://git.kernel.org/cgit/linux/kernel/git/vkoul/slave
> > -dma.git/commit/?h=fixes&id=5dd90e5b91e0f5c925b12b132c7cd2753887025
> > 6
> >
> > I don't know if this is the same issue... can you describe exactly
> > what you are trying to fix, why and how?
> >
> >
>
> This was about "choppy sound" issue left after the dma pause fix:
> https://www.mail-archive.com/linux-samsung
> -soc%40vger.kernel.org/msg44567.html
>
> From a glance at the commit you mention I would say it is the same
> issue. Will try this commit instead in a few hours and report.
The commit of yours, that is
https://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-dma.git/commit
/?h=fixes&id=5dd90e5b91e0f5c925b12b132c7cd2753887025 ,
fixes Odroid U2/U3 "choppy sound" too.
Thanks.
Alban
>
> > choppy sound) on Odroid XU3-Lite. On current linux-next
> > (next-20150612) the sound is awful (choppy) after few seconds of
> > play.
> > For example first four of:
> > $ aplay /usr/share/sounds/alsa/Front_Right.wav
> > work fine. But then it just gets worse and underruns are reported:
> > $ Playing WAVE '/usr/share/sounds/alsa/Front_Right.wav' : Signed 16
> > bit Little Endian, Rate 48000 Hz, Mono
prev parent reply other threads:[~2015-07-08 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 11:05 [PATCH] [RFC PATCH] dmaengine: pl330: residual - do not reset on last descriptor Alban Browaeys
2015-07-07 11:53 ` Krzysztof Kozlowski
2015-07-07 12:13 ` Alban Browaeys
2015-07-08 10:54 ` Alban Browaeys [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436352884.1160.6.camel@gmail.com \
--to=alban.browaeys@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=gabriel@unseen.is \
--cc=k.kozlowski@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=r.baldyga@samsung.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox