From: Tomasz Figa <tomasz.figa@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Inki Dae <inki.dae@samsung.com>,
'Joonyoung Shim' <jy0922.shim@samsung.com>,
'Seung-Woo Kim' <sw0312.kim@samsung.com>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'David Airlie' <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] drm/exynos: Add missing includes
Date: Sat, 06 Jul 2013 01:41:02 +0200 [thread overview]
Message-ID: <1504355.0ZFzGzMgKd@flatron> (raw)
In-Reply-To: <20130702150449.GO27646@sirena.org.uk>
On Tuesday 02 of July 2013 16:04:49 Mark Brown wrote:
> On Tue, Jul 02, 2013 at 09:21:32PM +0900, Inki Dae wrote:
> > > Ensure that all externally accessed functions are correctly
> > > prototyped
> > > when defined in each file by making sure the headers with the
> > > protoypes
> > > are included in the file with the definition.
> >
> > I don't see why this patch is needed. it seems like including
> > unnecessary headers so it makes the code size enlarged.
>
> Well, aside from it being basic good practice and allowing the compiler
> to check for errors in the prototypes this is also something that sparse
> warns about.
>
> If the resulting binary size is changed by having the headers included
> then that indicates a bug in the headers - they *really* shouldn't be
> doing anything substantial here. None of the headers in question looked
> at all worrying.
+1
Best regards,
Tomasz
next prev parent reply other threads:[~2013-07-05 23:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 12:55 [PATCH] drm/exynos: Add missing includes Mark Brown
2013-07-02 12:21 ` Inki Dae
2013-07-02 15:04 ` Mark Brown
2013-07-05 23:41 ` Tomasz Figa [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-12 23:46 Mark Brown
2013-08-13 2:27 ` Inki Dae
2013-08-13 9:53 ` Mark Brown
2013-08-13 10:52 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504355.0ZFzGzMgKd@flatron \
--to=tomasz.figa@gmail.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox