Re: [PATCH v3 00/10] Add helper for plane reset

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Alex,

On Monday, 6 August 2018 14:07:27 EEST Alexandru-Cosmin Gheorghe wrote:
> Hi,
> 
> On Sat, Aug 04, 2018 at 05:15:20PM +0100, Alexandru Gheorghe wrote:
> > No significant change since v2, fixed a spelling mistake and
> > added/removed some newlines in 01 and 07 patches.
> > 
> > I plan to apply the first patch of the series and the patches for
> > the drivers maintained through drm-misc(that go Reviewed/Ack) in
> > drm-misc-next on Monday.
> > 
> > For the other drivers please let me know if you want me to push them
> > in drm-misc-next as well.
> 
> Pushed the following patch to drm-misc-next:
> 
> drm/atomic: Add __drm_atomic_helper_plane_reset
> drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying the
> logic
> drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the
> logic
> drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic
> drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the logic

I've acked the rcar-du part, could it be merged with the rest of the code ?

> > Changes since v1:
> >  - Make __drm_atomic_helper_plane_reset consistent with the other
> >    helpers and require that both plane and state not be NULL,
> >    suggested by Boris Brezillon and Philipp Zabel. Drivers already
> >    check for that.
> >  
> >  - Add a proper commit message for driver changes.
> > 
> > Drivers that subclass drm_plane need to copy the logic for linking the
> > drm_plane with its state and to initialize core properties to their
> > default values. E.g (alpha and rotation)
> > 
> > Having a helper to reset the plane_state makes sense because of multiple
> > reasons:
> > 1. Eliminate code duplication.
> > 2. Add a single place for initializing core properties to their
> > default values, no need for driver to do it if what the helper sets
> > makes sense for them.
> > 3. No need to debug the driver when you enable a core property and
> > observe it doesn't have a proper default value.
> > 
> > Tested with mali-dp the other drivers are just built-tested.
> > 
> > Alexandru Gheorghe (10):
> >   drm/atomic: Add  __drm_atomic_helper_plane_reset
> >   drm/amd/display: Use __drm_atomic_helper_plane_reset instead of
> >     copying the logic
> >   drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying
> >     the logic
> >   drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of
> >     copying the logic
> >   drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the
> >     logic
> >   drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the
> >     logic
> >   drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying
> >     the logic
> >   drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the
> >     logic
> >   drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the
> >     logic
> >   drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the
> >     logic
> >  
> >  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  7 ++--
> >  drivers/gpu/drm/arm/malidp_planes.c           |  7 ++--
> >  .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c   |  5 +--
> >  drivers/gpu/drm/drm_atomic_helper.c           | 33 ++++++++++++++-----
> >  drivers/gpu/drm/exynos/exynos_drm_plane.c     |  3 +-
> >  drivers/gpu/drm/imx/ipuv3-plane.c             |  8 ++---
> >  drivers/gpu/drm/rcar-du/rcar_du_plane.c       |  6 ++--
> >  drivers/gpu/drm/rcar-du/rcar_du_vsp.c         |  5 +--
> >  drivers/gpu/drm/sun4i/sun4i_layer.c           |  4 +--
> >  drivers/gpu/drm/vc4/vc4_plane.c               |  4 +--
> >  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c           |  4 +--
> >  include/drm/drm_atomic_helper.h               |  2 ++
> >  12 files changed, 41 insertions(+), 47 deletions(-)

-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel