From: Tomasz Figa <tomasz.figa@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Tomasz Figa <t.figa@samsung.com>,
Andrew Bresticker <abrestic@chromium.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH 2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks
Date: Fri, 20 Dec 2013 22:14:28 +0100 [thread overview]
Message-ID: <1644725.nymfPqUWVu@flatron> (raw)
In-Reply-To: <CAK9yfHxuNxqJR7MV0vb+ThD3pQi6OPUfGv=Tg2KGZfzJwKm3eQ@mail.gmail.com>
On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:
> Hi Tomasz,
>
> On 19 December 2013 19:40, Tomasz Figa <t.figa@samsung.com> wrote:
> > Hi Sachin, Andrew,
> >
> > On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:
> >> Hi Tomasz,
> >>
> >> On 10 November 2013 22:38, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> >> > Hi Sachin, Andrew,
> >> >
> >> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
> >> >> From: Andrew Bresticker <abrestic@chromium.org>
> >> >>
> >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
> >> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
> >> >> Fix this so that the MFC will start up.
> >> >
> >> > Wow, this means that there is a mistake in the documentation. Not that
> >> > I'm surprised, though.
> >> >
> >> > I guess you are sure about this, so:
> >> >
> >> > Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> >>
> >> I believe you are going to take this through your tree along with a
> >> few others which you have already reviewed?
> >
> > This patch seems to depend on my Exynos 5250 clock clean-up series, which
> > will be merged for 3.14. Are you okay with this patch being merged for
> > 3.14 as well or this fix is needed for earlier kernel versions too?
> > (It is not a regression introduced in 3.13, though.)
>
> Yes, I did rebase it on top of your series along with other patches.
> Though not a regression introduced in 3.13, I think it makes sense to have this
> sent as a fix during this release (3.13) itself. Let me know if you
> want me to base it
> on top of 3.13-rc4 and re-send.
Since this is just a trivial fix, let me do it myself when applying.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-12-20 21:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 10:14 [PATCH 1/3] clk: exynos5250: save/restore EPLL0 configuration Sachin Kamat
2013-11-08 10:14 ` [PATCH 2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks Sachin Kamat
2013-11-10 17:08 ` Tomasz Figa
2013-11-11 3:11 ` Sachin Kamat
2013-12-18 18:09 ` Sachin Kamat
2013-12-18 18:28 ` Tomasz Figa
2013-12-18 19:24 ` Mike Turquette
2013-12-19 0:36 ` Tomasz Figa
2013-12-19 14:10 ` Tomasz Figa
2013-12-19 15:35 ` Sachin Kamat
2013-12-20 21:14 ` Tomasz Figa [this message]
2013-12-21 4:07 ` Sachin Kamat
2013-12-30 17:52 ` Tomasz Figa
2013-12-31 2:51 ` Sachin Kamat
2013-11-08 10:14 ` [PATCH 3/3] clk: exynos5250: register APLL rate table Sachin Kamat
2013-11-10 17:14 ` Tomasz Figa
2013-12-19 3:44 ` Sachin Kamat
2013-12-31 3:16 ` Sachin Kamat
2014-01-02 15:22 ` Tomasz Figa
2013-11-08 10:21 ` [PATCH 1/3] clk: exynos5250: save/restore EPLL0 configuration Sachin Kamat
2013-11-10 17:01 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644725.nymfPqUWVu@flatron \
--to=tomasz.figa@gmail.com \
--cc=abrestic@chromium.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox