From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v6 13/20] pwm: Add new pwm-samsung driver Date: Thu, 08 Aug 2013 14:27:07 -0700 (PDT) Message-ID: <1914245.MWaKtJIXGf@flatron> References: <1374278673-25615-1-git-send-email-tomasz.figa@gmail.com> <4144776.HcbubHMX0J@flatron> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-bk0-f45.google.com ([209.85.214.45]:40862 "EHLO mail-bk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966555Ab3HHV1J (ORCPT ); Thu, 8 Aug 2013 17:27:09 -0400 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Andrew Bresticker Cc: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , linux-pwm@vger.kernel.org, Kukjin Kim , Arnd Bergmann , Olof Johansson , Sylwester Nawrocki , Heiko =?ISO-8859-1?Q?St=FCbner?= , Mark Brown , Thierry Reding On Thursday 08 of August 2013 10:13:27 Andrew Bresticker wrote: > > ..it should not be defined as non-static in this case (= an ifdef is > > needed in this header). I believe I had this already fixed, not sure > > what happened with the fix... > > Perhaps this is it: https://patchwork.kernel.org/patch/2787271/. That > should probably land with this patchset too. Oh yes, this is it. I know what happened now. This series was already queued for 3.11 in Samsung tree. After a bit of testing in linux-next Bart found the build error and sent a fix, which was going to be merged for 3.11 as well. However since there have been some problems just before merge window started, this series had to be dropped, including the fixup patch. Thanks for reporting. Let me try to sort this out. Best regards, Tomasz