From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
lrg@slimlogic.co.uk, linux-samsung-soc@vger.kernel.org,
Jassi Brar <jassi.brar@samsung.com>
Subject: Re: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver
Date: Tue, 26 Jan 2010 10:53:22 +0000 [thread overview]
Message-ID: <20100126105322.GG15759@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1b68c6791001252332l5ee275c9we39c98691ad7692c@mail.gmail.com>
On Tue, Jan 26, 2010 at 04:32:45PM +0900, jassi brar wrote:
> On Tue, Jan 26, 2010 at 2:51 PM, <jassisinghbrar@gmail.com> wrote:
Please delete irrelevant context when replying to mails, it's much
easier to find the actual new text in the message that way.
> > + /* NOTE: If the codec ouputs just one slot,
> > + * it *seems* our AC97 controller reads the only
> > + * valid slot(if either 3 or 4) for PCM-In.
> > + * For such cases, we record Mono.
> > + */
> > + .channels_min = 1,
> I would like to remove this anomaly and set channels_min = 2
Why?
> And remove the second DAI_LINK in machine driver.
Again, why?
next prev parent reply other threads:[~2010-01-26 10:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 5:51 [PATCH 1/3] ARM: S3C64XX: Add AC97 platform resources jassisinghbrar
2010-01-26 5:51 ` [PATCH 2/3] ASoC: AC97: S3C: Add controller driver jassisinghbrar
2010-01-26 5:51 ` [PATCH 3/3] ARM: SMDK64XX: Enable AC97 device jassisinghbrar
2010-01-26 10:19 ` Mark Brown
2010-01-26 10:52 ` jassi brar
2010-01-26 10:59 ` Mark Brown
2010-01-26 7:32 ` [PATCH 2/3] ASoC: AC97: S3C: Add controller driver jassi brar
2010-01-26 10:53 ` Mark Brown [this message]
2010-01-26 11:49 ` jassi brar
2010-01-26 10:23 ` Ben Dooks
2010-01-26 11:03 ` jassi brar
2010-01-26 11:09 ` Mark Brown
2010-01-26 11:57 ` jassi brar
2010-01-26 12:04 ` Mark Brown
2010-01-27 2:45 ` jassi brar
2010-01-27 10:25 ` Mark Brown
2010-01-26 10:47 ` Mark Brown
2010-01-26 11:17 ` jassi brar
2010-01-26 11:52 ` Mark Brown
2010-01-26 12:11 ` jassi brar
2010-01-26 13:00 ` Mark Brown
2010-01-26 10:12 ` [PATCH 1/3] ARM: S3C64XX: Add AC97 platform resources Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126105322.GG15759@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox