From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-samsung-soc@vger.kernel.org,
'Russell King' <linux@arm.linux.org.uk>,
Kukjin Kim <kgene.kim@samsung.com>,
'Ben Dooks' <ben-linux@fluff.org>,
'Abdoulaye Walsimou GAYE' <awg@embtoolkit.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set, get}_pull callbacks
Date: Tue, 30 Nov 2010 14:01:43 +0200 [thread overview]
Message-ID: <201011301401.44973.anarsoul@gmail.com> (raw)
In-Reply-To: <4CF4E5C7.5020600@metafoo.de>
On Tuesday 30 November 2010 13:53:43 Lars-Peter Clausen wrote:
> > Hmm...how about s3c_gpio_setpull_1updown(...)?
> > And actually, not used 3rd argument, "pull" now.
> > I prefer follwoing.
>
> You need the 4th arguemnt, because the s3c2440 only supports pullups and
> the s3c2442 only supports pulldowns. So you want to return -EINVAL if
> somebody tries to set a pullup on a s3c2442 based board.
> Your proposed solution would return 0 and set a pulldown instead.
Well, at least it allows single-binary kernel for s3c24xx to exist. I think
it's OK, as setting pull{up,down} bit for any non S3C_GPIO_PULL_NONE arg
preserves semantics for all SoCs (s3c2410/s3c2440/s3c2442) by cost of not
handling errors. Anyway, who wants to call cfgpull with S3C_GPIO_PULL_DOWN on
s3c2410/s3c2440 or with S3C_GPIO_PULL_UP on s3c2442?
Regards
Vasily
next prev parent reply other threads:[~2010-11-30 12:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 22:00 [PATCH] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Lars-Peter Clausen
2010-09-20 22:00 ` [PATCH] ARM: s3c24xx: Set ARCH_NR_GPIOS according to the selected SoC types Lars-Peter Clausen
2010-09-20 23:41 ` [PATCH] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Ben Dooks
2010-09-21 5:28 ` Abdoulaye Walsimou GAYE
2010-11-06 7:54 ` [PATCH v2] " Vasily Khoruzhick
[not found] ` <4CD57DC1.4050403@embtoolkit.org>
2010-11-08 9:08 ` Vasily Khoruzhick
2010-11-08 20:26 ` [PATCH v3] " Vasily Khoruzhick
2010-11-08 21:41 ` Abdoulaye Walsimou GAYE
2010-11-29 9:56 ` Vasily Khoruzhick
2010-11-29 10:15 ` Kukjin Kim
2010-11-29 10:26 ` [PATCH RESEND " Vasily Khoruzhick
2010-11-30 6:18 ` Kukjin Kim
2010-11-30 11:53 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set, get}_pull callbacks Lars-Peter Clausen
2010-11-30 12:01 ` Vasily Khoruzhick [this message]
2010-11-30 13:12 ` [PATCH RESEND v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Lars-Peter Clausen
2010-11-30 14:33 ` Vasily Khoruzhick
2010-11-30 14:53 ` Lars-Peter Clausen
2010-11-30 15:01 ` Vasily Khoruzhick
2010-11-30 19:46 ` [PATCH v4] ARM: s3c244x: Fix mess with " Vasily Khoruzhick
[not found] ` <1291146383-16215-1-git-send-email-anarsoul@gmail.com>
2010-11-30 19:59 ` Lars-Peter Clausen
2010-11-30 20:05 ` Vasily Khoruzhick
2010-11-30 20:12 ` [PATCH v5] " Vasily Khoruzhick
2010-12-01 7:26 ` Kukjin Kim
2010-12-01 10:17 ` Vasily Khoruzhick
2010-12-01 12:05 ` Kukjin Kim
2010-12-01 12:16 ` Vasily Khoruzhick
2010-12-01 5:28 ` [PATCH v4] " Kukjin Kim
2010-12-01 6:19 ` Vasily Khoruzhick
2010-12-01 6:29 ` [PATCH v6] " Vasily Khoruzhick
2010-12-01 5:19 ` [PATCH RESEND v3] ARM: s3c2442: Setup " Kukjin Kim
2010-11-29 10:28 ` [PATCH " Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011301401.44973.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=awg@embtoolkit.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox