From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg KH <greg@kroah.com>
Subject: Re: [PATCH v4 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed
 controller driver
Date: Thu, 14 Apr 2011 08:47:48 -0700
Message-ID: <20110414154748.GA1366@kroah.com>
References: <201104141111.33781.heiko@sntech.de>
 <Pine.LNX.4.44L0.1104141134260.2487-100000@iolanthe.rowland.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-samsung-soc-owner@vger.kernel.org>
Received: from kroah.org ([198.145.64.141]:34420 "EHLO coco.kroah.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759101Ab1DNPrx (ORCPT
	<rfc822;linux-samsung-soc@vger.kernel.org>);
	Thu, 14 Apr 2011 11:47:53 -0400
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44L0.1104141134260.2487-100000@iolanthe.rowland.org>
Sender: linux-samsung-soc-owner@vger.kernel.org
List-Id: linux-samsung-soc@vger.kernel.org
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Heiko =?iso-8859-1?Q?St=FCbner?= <heiko@sntech.de>, Kukjin Kim <kgene.kim@samsung.com>, Ben Dooks <ben-linux@fluff.org>, Thomas Abraham <thomas.ab@samsung.com>, Sangbeom Kim <sbkim73@samsung.com>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, Alexander Neumann <alexander@debian.org>

On Thu, Apr 14, 2011 at 11:35:43AM -0400, Alan Stern wrote:
> On Thu, 14 Apr 2011, Heiko [iso-8859-1] St?bner wrote:
> 
> > From: Thomas Abraham <thomas.ab@samsung.com>
> > 
> > The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed
> > device controller module. This driver enables support for USB high-speed
> > gadget functionality for the Samsung S3C24xx SoC's that include this
> > controller.
> > 
> > Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> > Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > Signed-off-by: Alexander Neumann <alexander@bumpern.de>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> ...
> 
> > +static struct usb_ep_ops s3c_hsudc_ep_ops = {
> > +	.enable = s3c_hsudc_ep_enable,
> > +	.disable = s3c_hsudc_ep_disable,
> > +	.alloc_request = s3c_hsudc_alloc_request,
> > +	.free_request = s3c_hsudc_free_request,
> > +	.queue = s3c_hsudc_queue,
> > +	.dequeue = s3c_hsudc_dequeue,
> > +	.set_halt = s3c_hsudc_set_halt,
> > +};
> 
> There's no .set_wedge method.  Why do people always leave this out?

Does the code spit out a nasty warning if this isn't set?  If not, I
would suggest adding it so that this doesn't keep happening.

Or just refuse to be able to register the structure, that would stop it
right away :)

thanks,

greg k-h